Skip to content

drm/mgag200: Control VIDRST and BMC from CRTC

Thomas Zimmermann dri-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 4 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- don't clear VIDRST bits unnecessarily (Jocelyn) v2:
- run BMC and VIDRST logic from CRTC code (Jocelyn)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/mgag200: Only set VIDRST bits in CRTC modesettingdrivers/gpu/drm/mgag200/mgag200_bmc.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200er.c +3 more+15 -130 replies
2/3drm/mgag200: Remove vidrst callbacks from struct mgag200_device_funcsdrivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200er.c drivers/gpu/drm/mgag200/mgag200_g200ev.c +4 more+10 -420 replies
3/3drm/mgag200: Rename BMC vidrst namesdrivers/gpu/drm/mgag200/mgag200_bmc.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200er.c +3 more+20 -200 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] drm/mgag200: Control VIDRST and BMC from CRTC

(was: drm/mgag200: Handle VIDRST from BMC helpers)

The VIDRST pin controls CRTC synchronization with an external clock chip, such as a BMC or TV encoder. This patchset separates the CRTC state from the BMC state and streamlines the driver code.

v3:
- don't clear VIDRST bits unnecessarily (Jocelyn) v2:
- run BMC and VIDRST logic from CRTC code (Jocelyn)

Thomas Zimmermann (3):
drm/mgag200: Only set VIDRST bits in CRTC modesetting drm/mgag200: Remove vidrst callbacks from struct mgag200_device_funcs drm/mgag200: Rename BMC vidrst names

 drivers/gpu/drm/mgag200/mgag200_bmc.c     |  9 ++-----
 drivers/gpu/drm/mgag200/mgag200_drv.h     | 31 ++++++++---------------
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |  9 +++----
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |  9 +++----
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |  2 --
 drivers/gpu/drm/mgag200/mgag200_g200se.c  |  9 +++----
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |  2 --
 drivers/gpu/drm/mgag200/mgag200_mode.c    | 27 +++++++++-----------
 8 files changed, 34 insertions(+), 64 deletions(-)
Signature · 1 line
2.45.2