Skip to content

tcp: Make simultaneous connect() RFC-compliant.

Kuniyuki Iwashima netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 5 repliesApplied 2/2
  2. v22 patches 6 repliesSuperseded
  3. v11 patch 12 repliesSuperseded

Changes in v3 from the cover letter

* Use (sk->sk_state == TCP_SYN_RECV && sk->sk_socket) to detect cross SYN case

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2tcp: Don't drop SYN+ACK for simultaneous connect().net/ipv4/tcp_input.c+9 -05 repliesApplied
2/2selftests: tcp: Remove broken SNMP assumptions for TCP AO self-connect tests.tools/testing/selftests/net/tcp_ao/self-connect.c+0 -180 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric DumazetDmitry Safonov
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/2] tcp: Make simultaneous connect() RFC-compliant.

Patch 1 fixes an issue that BPF TCP option parser is triggered for ACK instead of SYN+ACK in the case of simultaneous connect().

Patch 2 removes an wrong assumption in tcp_ao/self-connnect tests.

v3:
* Use (sk->sk_state == TCP_SYN_RECV && sk->sk_socket) to detect cross SYN case

v2: https://lore.kernel.org/netdev/[email protected]/
* Target net-next and remove Fixes: tag
* Don't skip bpf_skops_parse_hdr() to centralise sk_state check
* Remove unnecessary ACK after SYN+ACK
* Add patch 2

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (2):
tcp: Don't drop SYN+ACK for simultaneous connect().
selftests: tcp: Remove broken SNMP assumptions for TCP AO self-connect
tests.

 net/ipv4/tcp_input.c                           |  9 +++++++++
 .../selftests/net/tcp_ao/self-connect.c        | 18 ------------------
 2 files changed, 9 insertions(+), 18 deletions(-)
Signature · 1 line
2.30.2