Skip to content

Resolve vt82c686 and piix4 qemu_irq memory leaks

Bernhard Beschow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/isa/vt82c686: Turn "intr" irq into a named gpiohw/isa/vt82c686.c hw/mips/fuloong2e.c hw/ppc/amigaone.c +1 more+6 -63 replies
2/3hw/isa/vt82c686: Resolve intermediate IRQ forwarderhw/isa/vt82c686.c hw/mips/fuloong2e.c hw/ppc/amigaone.c +1 more+9 -172 replies
3/3hw/isa/piix: Resolve intermediate IRQ forwarderhw/isa/piix.c hw/mips/malta.c+3 -140 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéBALATON Zoltan
1/3R-b R-b
2/3Inspired-by
3/3Inspired-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Resolve vt82c686 and piix4 qemu_irq memory leaks

This series first turns vt82c686's "INTR" pin into a named GPIO for better comprehensibility. It then continues fixing qemu_irq memory leaks in vt82c686 and piix4 by connecting out IRQs of the south bridges before they get realized. This approach is already used in the pc machines after it had been discussed at KVM forum `23.

Observe that out IRQs are callbacks such as an INTR IRQ handler in a CPU which a south bridge wants to trigger. If, as an implementation detail, the south bridge wants to pass this callback to a child device, such as the PIC, then this callback must be known to the south bridge before it gets realized. Otherwise board code had to wire the PIC device itself, breaking encapsulation. This means that qdev_connect_gpio_out*() has to be called before realize() which this series implements. Another way to look at it is that callbacks apparently are resouces such as memory regions which are also populated before realize().

Please check if above paragraph makes sense.

Best regards,
Bernhard

See also:
* https://lore.kernel.org/qemu-devel/0FFB5FD2-08CE-4CEC-9001-E7AC24407A44@gmail.
com/
* "Remove intermediate IRQ forwarder" patches in
https://lore.kernel.org/qemu-devel/[email protected]/

Testing done:
* Boot amigaone machine into Linux
* Boot pegasos2 machine into MorphOS
* Start fuloong2e machine and check that it doesn't abort
* Boot malta machine with https://people.debian.org/~gio/dqib/

Bernhard Beschow (3):
hw/isa/vt82c686: Turn "intr" irq into a named gpio hw/isa/vt82c686: Resolve intermediate IRQ forwarder hw/isa/piix: Resolve intermediate IRQ forwarder

 hw/isa/piix.c       | 13 ++-----------
 hw/isa/vt82c686.c   | 12 ++----------
 hw/mips/fuloong2e.c |  2 +-
 hw/mips/malta.c     |  4 +---
 hw/ppc/amigaone.c   |  8 ++++----
 hw/ppc/pegasos2.c   |  4 ++--
 6 files changed, 12 insertions(+), 31 deletions(-)
Signature · 1 line
2.45.2