bnxt_en: address string truncation
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 2 repliesApplied 2/2
- v13 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- Added patch:
+ bnxt_en: Extend maximum length of version string by 1 byte
- Dropped the following patches.
- bnxt_en: check for irq name truncation
- bnxt_en: check for fw_ver_str truncation
+ The approach I had taken was to return error on truncation, but the feedback I received was that it would be better to replace the last three bytes with "..." or some other similar scheme. While simple enough to implement, it does add some complexity, and I have so far been unable to convince myself that it is warranted. So I have decided to drop these patches for now.
- Link to v1: https://lore.kernel.org/r/[email protected]
Patches in v2 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bnxt_en: Extend maximum length of version string by 1 bytedrivers/ | +1 | 1 reply | Applied |
| 2/2 | bnxt_en: avoid truncation of per rx run debugfs filenamedrivers/ | +2 | 1 reply | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Michael Chan |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/2] bnxt_en: address string truncation
Hi,
This series addresses several string truncation issues that are flagged by gcc-14. I do not have any reason to believe these are bugs, so I am targeting this at net-next and have not provided Fixes tags.
---
Changes in v2:
- Added patch:
+ bnxt_en: Extend maximum length of version string by 1 byte
- Dropped the following patches.
- bnxt_en: check for irq name truncation
- bnxt_en: check for fw_ver_str truncation
+ The approach I had taken was to return error on truncation, but the feedback I received was that it would be better to replace the last three bytes with "..." or some other similar scheme. While simple enough to implement, it does add some complexity, and I have so far been unable to convince myself that it is warranted. So I have decided to drop these patches for now.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Simon Horman (2):
bnxt_en: Extend maximum length of version string by 1 byte
bnxt_en: avoid truncation of per rx run debugfs filename
drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
base-commit: dd1bf9f9df156b43e5122f90d97ac3f59a1a5621