Skip to content

fs/dcache: fix cache inconsistency on case-insensitive lookups

Eugen Hristev linux-ext4 linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fs/dcache: introduce d_alloc_parallel_check_existingfs/dcache.c include/linux/dcache.h+27 -65 replies
2/2ext4: in lookup call d_add_ci if there is a case mismatchfs/ext4/namei.c+13 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] fs/dcache: fix cache inconsistency on case-insensitive lookups

Hello,

This is an attempt to go back to this old patch series here :

https://lore.kernel.org/lkml/[email protected]/

First patch fixes a possible hang when d_add_ci is called from a filesystem's lookup function (like xfs is doing)
d_alloc_parallel -> lookup -> d_add_ci -> d_alloc_parallel

Second patch solves the issue of having the dcache saving the entry with the same case as it's being looked up instead of saving the real file name from the storage.
Please check above thread for motivation on why this should be changed.

Some further old discussions here as well:
https://patchwork.ozlabs.org/project/linux-ext4/patch/[email protected]/

I am not sure whether this is the right way to fix this, but I think I have considered all cases discussed in previous threads.

Thank you for your review and consideration,
Eugen

Eugen Hristev (2):
fs/dcache: introduce d_alloc_parallel_check_existing
ext4: in lookup call d_add_ci if there is a case mismatch

 fs/dcache.c            | 29 +++++++++++++++++++++++------
 fs/ext4/namei.c        | 13 +++++++++++++
 include/linux/dcache.h |  4 ++++
 3 files changed, 40 insertions(+), 6 deletions(-)
Signature · 1 line
2.34.1