Introduce drm sharpening property
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drm: Introduce sharpness mode propertydrivers/ drivers/ include/ | +56 | 0 replies | |
| 2/5 | drm/i915/display: Compute the scaler filter coefficientsdrivers/ drivers/ drivers/ +4 more | +163 | 0 replies | |
| 3/5 | drm/i915/display: Enable the second scaler for sharpnessdrivers/ drivers/ drivers/ +5 more | +99 | 0 replies | |
| 4/5 | drm/i915/display: Add registers and compute the strengthdrivers/ drivers/ drivers/ +2 more | +132 | 0 replies | |
| 5/5 | drm/i915/display: Load the lut values and enable sharpnessdrivers/ drivers/ drivers/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Introduce drm sharpening property
Many a times images are blurred or upscaled content is also not as
crisp as original rendered image. Traditional sharpening techniques often apply a uniform level of enhancement across entire image, which sometimes result in over-sharpening of some areas and potential loss of natural details.
Intel has come up with Display Engine based adaptive sharpening filter with minimal power and performance impact. From LNL onwards, the Display hardware can use one of the pipe scaler for adaptive sharpness filter. This can be used for both gaming and non-gaming use cases like photos, image viewing. It works on a region of pixels depending on the tap size.
This is an attempt to introduce an adaptive sharpness solution which helps in improving the image quality. For this new CRTC property is added. The user can set this property with desired sharpness strength value with 0-255. A value of 1 representing minimum sharpening strength and 255 representing maximum sharpness strength. A strength value of 0 means no sharpening or sharpening feature disabled.
It works on a region of pixels depending on the tap size. The coefficients are used to generate an alpha value which is used to blend the sharpened image to original image.
Middleware MR link: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3665
IGT patchwork link: https://patchwork.freedesktop.org/series/130218/
--v3: Added uapi documentation.
Made sharpness word consistent.
Nemesa Garg (5):
drm: Introduce sharpness mode property drm/i915/display: Compute the scaler filter coefficients drm/i915/display: Enable the second scaler for sharpness drm/i915/display: Add registers and compute the strength drm/i915/display: Load the lut values and enable sharpness
drivers/gpu/drm/drm_atomic_uapi.c | 4 + drivers/gpu/drm/drm_crtc.c | 35 +++ drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_crtc.c | 3 + drivers/gpu/drm/i915/display/intel_display.c | 21 +- .../drm/i915/display/intel_display_types.h | 11 + .../drm/i915/display/intel_modeset_verify.c | 1 + drivers/gpu/drm/i915/display/intel_panel.c | 4 +- .../drm/i915/display/intel_sharpen_filter.c | 236 ++++++++++++++++++ .../drm/i915/display/intel_sharpen_filter.h | 33 +++ drivers/gpu/drm/i915/display/skl_scaler.c | 97 ++++++- drivers/gpu/drm/i915/display/skl_scaler.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 19 ++ drivers/gpu/drm/xe/Makefile | 1 + include/drm/drm_crtc.h | 17 ++ 15 files changed, 470 insertions(+), 14 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_sharpen_filter.c create mode 100644 drivers/gpu/drm/i915/display/intel_sharpen_filter.h
Signature · 1 line
2.25.1