Skip to content

drm/mgag200: Implement VBLANK support

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 24 repliesIn review
  2. v47 patches 9 repliesSuperseded

Changes in v5 from the cover letter

- clear all interrupts before registering IRQ (Jocelyn)
- don't read from ICLEAR (Jocelyn)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/mgag200: Use hexadecimal register indecesdrivers/gpu/drm/mgag200/mgag200_mode.c+25 -250 replies
2/7drm/mgag200: Align register field names with documentationdrivers/gpu/drm/mgag200/mgag200_mode.c+27 -270 replies
3/7drm/mgag200: Use adjusted mode values for CRTCsdrivers/gpu/drm/mgag200/mgag200_mode.c+8 -80 replies
4/7drm/mgag200: Add dedicated variables for blanking fieldsdrivers/gpu/drm/mgag200/mgag200_mode.c+16 -130 replies
5/7drm/mgag200: Add dedicted variable for <linecomp> fielddrivers/gpu/drm/mgag200/mgag200_mode.c+7 -40 replies
6/7drm/mgag200: Add vblank supportdrivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c +9 more+143 -22 replies
7/7drm/mgag200: Implement struct drm_crtc_funcs.get_vblank_timestampdrivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_mode.c+33 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJocelyn FalempeSam RavnborgGerd HoffmannTony Luck
SeriesT-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7A-b
6/7T-b R-b A-b A-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/7] drm/mgag200: Implement VBLANK support

Implement support for VBLANK events in mgag200.

Patches 1 to 5 prepare mgag200's modesetting code by renaming or adding variables for various hardware fields. This makes the code more readable and aligns it with the programming manuals for Matrox hardware.

Patch 6 implements support for VBLANK events. The patch has been reviewed before at [1]. That old patchset never found its way into the kernel, but the VBLANK support is still useful.

Patch 7 adds support for VBLANK timestamps.

v5:
- clear all interrupts before registering IRQ (Jocelyn)
- don't read from ICLEAR (Jocelyn)

v4:
- split off the patchset from an earlier series [1]

[1] https://patchwork.freedesktop.org/series/66442/

Thomas Zimmermann (7):
drm/mgag200: Use hexadecimal register indeces drm/mgag200: Align register field names with documentation drm/mgag200: Use adjusted mode values for CRTCs drm/mgag200: Add dedicated variables for blanking fields drm/mgag200: Add dedicted variable for <linecomp> field drm/mgag200: Add vblank support
drm/mgag200: Implement struct drm_crtc_funcs.get_vblank_timestamp

 drivers/gpu/drm/mgag200/mgag200_drv.c     |  40 ++++++
 drivers/gpu/drm/mgag200/mgag200_drv.h     |  14 +-
 drivers/gpu/drm/mgag200/mgag200_g200.c    |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200se.c  |   5 +
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |   5 +
 drivers/gpu/drm/mgag200/mgag200_mode.c    | 167 ++++++++++++++++------
 drivers/gpu/drm/mgag200/mgag200_reg.h     |   7 +
 12 files changed, 223 insertions(+), 45 deletions(-)
Signature · 1 line
2.45.2