Skip to content

drm/{i915, xe}: FBC cleanups + tweak fbdev stolen usage

Ville Syrjala intel-gfx intel-xe oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 25 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20drm/i915/fbc: Extract intel_fbc_has_fences()drivers/gpu/drm/i915/display/intel_fbc.c+7 -21 reply
2/20drm/i915/fbc: Convert to intel_display, mostlydrivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/display/intel_fbc.c +3 more+239 -2082 replies
3/20drm/i915/fbc: s/_intel_fbc_cfb_stride()/intel_fbc_plane_cfb_stride()/drivers/gpu/drm/i915/display/intel_fbc.c+3 -31 reply
4/20drm/i915/fbc: Extract intel_fbc_max_plane_size()drivers/gpu/drm/i915/display/intel_fbc.c+18 -111 reply
5/20drm/i915/fbc: Extract intel_fbc_max_surface_size()drivers/gpu/drm/i915/display/intel_fbc.c+24 -171 reply
6/20drm/i915/fbc: s/intel_fbc_hw_tracking_covers_screen()/intel_fbc_surface_size_ok()/drivers/gpu/drm/i915/display/intel_fbc.c+2 -21 reply
7/20drm/i915/fbc: Adjust g4x+ platform checksdrivers/gpu/drm/i915/display/intel_fbc.c+2 -21 reply
8/20drm/i915/fbc: Extract _intel_fbc_cfb_stride()drivers/gpu/drm/i915/display/intel_fbc.c+14 -81 reply
9/20drm/i915/fbc: s/lines/height/drivers/gpu/drm/i915/display/intel_fbc.c+4 -41 reply
10/20drm/i915/fbc: Reoder CFB max height platform checksdrivers/gpu/drm/i915/display/intel_fbc.c+3 -31 reply
11/20drm/i915/fbc: Extract intel_fbc_max_cfb_height()drivers/gpu/drm/i915/display/intel_fbc.c+20 -72 replies
12/20drm/i915/fbc: Extract _intel_fbc_cfb_size()drivers/gpu/drm/i915/display/intel_fbc.c+7 -21 reply
13/20drm/i915/fbc: Extract intel_fbc_cfb_cpp()drivers/gpu/drm/i915/display/intel_fbc.c+12 -61 reply
14/20drm/i915/fbc: Introduce intel_fbc_preferred_cfb_size()drivers/gpu/drm/i915/display/intel_fbc.c drivers/gpu/drm/i915/display/intel_fbc.h+18 -01 reply
15/20drm/xe/fbdev: Fix BIOS FB vs.s stolen size checkedrivers/gpu/drm/xe/display/xe_plane_initial.c+1 -11 reply
16/20drm/i915/fbdev: Extract intel_fbdev_fb_prefer_stolen()drivers/gpu/drm/i915/display/intel_fbdev_fb.c drivers/gpu/drm/i915/display/intel_fbdev_fb.h drivers/gpu/drm/i915/display/intel_plane_initial.c+23 -163 replies
17/20drm/xe/fbdev: Extract intel_fbdev_fb_prefer_stolen()drivers/gpu/drm/xe/display/intel_fbdev_fb.c drivers/gpu/drm/xe/display/xe_plane_initial.c+20 -61 reply
18/20drm/xe/fbdev: Use the same logic for fbdev stolen takever and fresh allocationdrivers/gpu/drm/xe/display/intel_fbdev_fb.c+4 -11 reply
19/20drm/i915/fbdev: Adjust fbdev stolen mem usage heuristicdrivers/gpu/drm/i915/display/intel_fbdev_fb.c+5 -61 reply
20/20drm/xe/fbdev: Adjust fbdev stolen mem usage heuristicdrivers/gpu/drm/xe/display/intel_fbdev_fb.c+5 -61 reply

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviUma Shankar
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] drm/{i915, xe}: FBC cleanups + tweak fbdev stolen usage

From: Ville Syrjälä <[email protected]>

Here's an idea for a slightly better heuristic to answer the "should fbdev use stolen or not?" question.

Ended up with a pile of refactoring and cleanups in the FBC code as a result.

Ville Syrjälä (20):
drm/i915/fbc: Extract intel_fbc_has_fences()
drm/i915/fbc: Convert to intel_display, mostly drm/i915/fbc: s/_intel_fbc_cfb_stride()/intel_fbc_plane_cfb_stride()/ drm/i915/fbc: Extract intel_fbc_max_plane_size() drm/i915/fbc: Extract intel_fbc_max_surface_size() drm/i915/fbc:
s/intel_fbc_hw_tracking_covers_screen()/intel_fbc_surface_size_ok()/
drm/i915/fbc: Adjust g4x+ platform checks
drm/i915/fbc: Extract _intel_fbc_cfb_stride() drm/i915/fbc: s/lines/height/
drm/i915/fbc: Reoder CFB max height platform checks drm/i915/fbc: Extract intel_fbc_max_cfb_height() drm/i915/fbc: Extract _intel_fbc_cfb_size()
drm/i915/fbc: Extract intel_fbc_cfb_cpp()
drm/i915/fbc: Introduce intel_fbc_preferred_cfb_size() drm/xe/fbdev: Fix BIOS FB vs.s stolen size checke drm/i915/fbdev: Extract intel_fbdev_fb_prefer_stolen() drm/xe/fbdev: Extract intel_fbdev_fb_prefer_stolen() drm/xe/fbdev: Use the same logic for fbdev stolen takever and fresh
allocation
drm/i915/fbdev: Adjust fbdev stolen mem usage heuristic drm/xe/fbdev: Adjust fbdev stolen mem usage heuristic

 .../drm/i915/display/intel_display_debugfs.c  |   4 +-
 .../drm/i915/display/intel_display_driver.c   |   4 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      | 564 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_fbc.h      |  14 +-
 drivers/gpu/drm/i915/display/intel_fbdev_fb.c |  23 +-
 drivers/gpu/drm/i915/display/intel_fbdev_fb.h |   5 +-
 .../drm/i915/display/intel_fifo_underrun.c    |   2 +-
 .../drm/i915/display/intel_modeset_setup.c    |   2 +-
 .../drm/i915/display/intel_plane_initial.c    |  10 +-
 drivers/gpu/drm/xe/display/intel_fbdev_fb.c   |  22 +-
 drivers/gpu/drm/xe/display/xe_plane_initial.c |   8 +-
 11 files changed, 389 insertions(+), 269 deletions(-)
Signature · 1 line
2.44.2