Skip to content

perf/uprobe: Optimize uprobes

Peter Zijlstra bpf linux-trace-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 33 repliesIn review
  2. v110 patches 73 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11perf/uprobe: Re-indent labelskernel/events/uprobes.c+13 -132 replies
2/11perf/uprobe: Remove spurious whitespacekernel/events/uprobes.c+6 -60 replies
3/11rbtree: Provide rb_find_rcu() / rb_find_add_rcu()include/linux/rbtree.h+67 -03 replies
4/11perf/uprobe: RCU-ify find_uprobe()kernel/events/uprobes.c+40 -91 reply
5/11perf/uprobe: Simplify UPROBE_HANDLER_REMOVE logickernel/events/uprobes.c+14 -30 replies
6/11perf/uprobe: SRCU-ify uprobe->consumer listkernel/events/uprobes.c+50 -103 replies
7/11perf/uprobe: Split uprobe_unregister()include/linux/uprobes.h kernel/events/uprobes.c kernel/trace/bpf_trace.c +1 more+21 -71 reply
8/11perf/uprobe: Convert (some) uprobe->refcount to SRCUkernel/events/uprobes.c+41 -272 replies
9/11srcu: Add __srcu_clone_read_lock()include/linux/srcu.h include/linux/srcutiny.h kernel/rcu/srcutree.c+16 -00 replies
10/11perf/uprobe: Convert single-step and uretprobe to SRCUinclude/linux/uprobes.h kernel/events/uprobes.c+31 -315 replies
11/11perf/uprobe: Add uretprobe timerinclude/linux/uprobes.h kernel/events/uprobes.c+69 -67 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu (Google)Andrii Nakryiko
1/11
2/11
3/11R-b
4/11A-b
5/11
6/11
7/11A-b A-b
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] perf/uprobe: Optimize uprobes

Hi!

These patches implement the (S)RCU based proposal to optimize uprobes.

On my c^Htrusty old IVB-EP -- where each (of the 40) CPU calls 'func' in a tight loop:

perf probe -x ./uprobes test=func
perf stat -ae probe_uprobe:test -- sleep 1

perf probe -x ./uprobes test=func%return perf stat -ae probe_uprobe:test__return -- sleep 1

PRE:

4,038,804 probe_uprobe:test
2,356,275 probe_uprobe:test__return

POST:

7,216,579 probe_uprobe:test
6,744,786 probe_uprobe:test__return

(copy-paste FTW, I didn't do new numbers because the fast paths didn't change --
and quick test run shows similar numbers)

Patches also available here:

git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/uprobes

Changes since last time:
- better split with intermediate inc_not_zero()
- fix UPROBE_HANDLER_REMOVE
- restored the lost rcu_assign_pointer()
- avoid lockdep for uretprobe_srcu
- add missing put_uprobe() -> srcu_read_unlock() conversion
- actually initialize return_instance::has_ref
- a few comments
- things I don't remember