Skip to content

Add rounding macros and enable KUnit tests

Devarsh Thakkar linux-doc linux-media lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 10 repliesIn review
  2. v16 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Fix grammar in new rounding off macro descriptions
- Use roundup for rounclosest to avoid overflow

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6math.h: Add macros for rounding to the closest valueinclude/linux/math.h+63 -09 replies
2/6math.h: Use kernel-doc syntax for division macrosinclude/linux/math.h+17 -60 replies
3/6Documentation: core-api: Add math.h macros and functionsDocumentation/core-api/kernel-api.rst+6 -00 replies
4/6lib: Add basic KUnit test for lib/mathlib/math/Kconfig lib/math/Makefile lib/math/math_kunit.c+309 -00 replies
5/6lib: math_kunit: Add tests for new macros related to rounding to nearest valuelib/math/math_kunit.c+35 -01 reply
6/6media: imagination: Round to closest multiple for cropping regiondrivers/media/platform/imagination/e5010-jpeg-enc.c+4 -40 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoRandy DunlapDavid Gow
1/6A-b
2/6
3/6R-b R-b T-b
4/6R-b R-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] Add rounding macros and enable KUnit tests

This adds new rounding macros to round to closest integer along with enabling KUnit tests for all math.h macros. It also updates kernel-doc to render math.h related documentation and lastly updates the imagination jpeg encoder to use the newly introduced rounding macros to find nearest value.

Also to note that math.h is orphaned and so these changes need to be pulled by subsystem using them as discussed in below threads:

Link:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

Changelog:
V2:
- Fix grammar in new rounding off macro descriptions
- Use roundup for rounclosest to avoid overflow

Previous patch series:
https://lore.kernel.org/all/[email protected]/#t

Rangediff (V2->V1):
https://gist.github.com/devarsht/a3c4420869d3f66fdc88e0af6a0f0a95

Daniel Latypov (1):
lib: Add basic KUnit test for lib/math

Devarsh Thakkar (5):
math.h: Add macros for rounding to the closest value math.h: Use kernel-doc syntax for division macros
Documentation: core-api: Add math.h macros and functions
lib: math_kunit: Add tests for new macros related to rounding to
nearest value
media: imagination: Round to closest multiple for cropping region

 Documentation/core-api/kernel-api.rst         |   6 +
 .../platform/imagination/e5010-jpeg-enc.c     |   8 +-
 include/linux/math.h                          |  86 ++++-
 lib/math/Kconfig                              |  14 +
 lib/math/Makefile                             |   1 +
 lib/math/math_kunit.c                         | 329 ++++++++++++++++++
 6 files changed, 434 insertions(+), 10 deletions(-)
 create mode 100644 lib/math/math_kunit.c
Signature · 1 line
2.39.1