Binding and driver for "dumb" clock generators
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: clocks: add binding for generic clock-generatorsDocumentation/ | +62 | 8 replies | |
| 2/6 | clk: add driver for generic clock generatorsdrivers/ drivers/ drivers/ | +141 | 0 replies | |
| 3/6 | arm64: dts: rockchip: fix the pcie clock generator on Rock 5 ITXarch/ | +32 | 0 replies | |
| 4/6 | arm64: dts: rockchip: use clock-generator for pcie-refclk on rk3588-jaguararch/ | +4 | 0 replies | |
| 5/6 | arm64: dts: rockchip: use clock-generator for pcie-refclk on rk3588-tigerarch/ | +4 | 0 replies | |
| 6/6 | arm64: dts: rockchip: add pinctrl for clk-generator gpio on rk3588-tigerarch/ | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] Binding and driver for "dumb" clock generators
Rockchip boards with PCIe3 controllers inside the soc (rk3568, rk3588) have external clock generators on the board to generate the needed 100MHz reference clock the PCIe3 controller needs.
Often these clock generators need supplies to be enabled to run.
Modelling this clock has taken a number of shapes:
- The rk3568 Rock-3a modelled the generator-regulator as "phy-supply" [0] &pcie30phy {
phy-supply = <&vcc3v3_pi6c_03>;
status = "okay";
};
which is of course not part of the binding
- On the Rock-5-ITX the supply of the clock generator is controlled by the same gpio as the regulator supplying the the port connected to the pcie30x4 controller, so if this controller probes first, both controllers will just run. But if the pcie30x2 controller probes first (which has a different supply), the controller will stall at the first dbi read.
- Recent Theobroma-Systems boards (Jaguar and Tiger) modelled their generator as a combination of fixed clock and gpio-gate, which works because the generator's vdd-supply is always on and only the output- enable pin needs to be toggled.
So this series attempts to improve the situation by allowing to model these clock generators as actual entities in the devicetree, to not have them just accidentially work or break bindings.
Heiko Stuebner (6):
dt-bindings: clocks: add binding for generic clock-generators
clk: add driver for generic clock generators
arm64: dts: rockchip: fix the pcie clock generator on Rock 5 ITX
arm64: dts: rockchip: use clock-generator for pcie-refclk on
rk3588-jaguar
arm64: dts: rockchip: use clock-generator for pcie-refclk on
rk3588-tiger
arm64: dts: rockchip: add pinctrl for clk-generator gpio on
rk3588-tiger.../bindings/clock/clock-generator.yaml | 62 ++++++++ .../arm64/boot/dts/rockchip/rk3588-jaguar.dts | 13 +- .../boot/dts/rockchip/rk3588-rock-5itx.dts | 34 ++++- .../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 21 +-- drivers/clk/Kconfig | 7 + drivers/clk/Makefile | 1 + drivers/clk/clk-generator.c | 133 ++++++++++++++++++ 7 files changed, 251 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/clock-generator.yaml create mode 100644 drivers/clk/clk-generator.c
Signature · 1 line
2.39.2