Skip to content

firmware: cs_dsp: Some small coding improvements

Richard Fitzgerald alsa-devel linux-sound lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Replaced commit #3 with one that keeps the wmfw format version message on its own line instead of merging it into the INFO text message.
- Commit #4 rebased onto the new #3

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4firmware: cs_dsp: Don't allocate temporary buffer for info textdrivers/firmware/cirrus/cs_dsp.c+7 -280 replies
2/4firmware: cs_dsp: Make wmfw and bin filename arguments const char *drivers/firmware/cirrus/cs_dsp.c include/linux/firmware/cirrus/cs_dsp.h+8 -80 replies
3/4firmware: cs_dsp: Clarify wmfw format version log messagedrivers/firmware/cirrus/cs_dsp.c+2 -30 replies
4/4firmware: cs_dsp: Rename fw_ver to wmfw_verdrivers/firmware/cirrus/cs_dsp.c include/linux/firmware/cirrus/cs_dsp.h sound/soc/codecs/wm_adsp.c+12 -120 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCharles Keepax
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] firmware: cs_dsp: Some small coding improvements

Commit series that makes some small improvements to code and the kernel log messages.

---
Changes since V1:
- Replaced commit #3 with one that keeps the wmfw format version message on its own line instead of merging it into the INFO text message.
- Commit #4 rebased onto the new #3

Richard Fitzgerald (4):
firmware: cs_dsp: Don't allocate temporary buffer for info text
firmware: cs_dsp: Make wmfw and bin filename arguments const char *
firmware: cs_dsp: Clarify wmfw format version log message
firmware: cs_dsp: Rename fw_ver to wmfw_ver

 drivers/firmware/cirrus/cs_dsp.c       | 68 +++++++++-----------------
 include/linux/firmware/cirrus/cs_dsp.h | 10 ++--
 sound/soc/codecs/wm_adsp.c             |  2 +-
 3 files changed, 29 insertions(+), 51 deletions(-)
Signature · 1 line
2.39.2