ppc/pnv: Better big-core model, lpar-per-core, PC unit
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest19 patches 6 repliesIn review
- v219 patches 12 repliesSuperseded
- v118 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- Converted big-core, lpar-per-core, and big-core tb quirk to object properties APIs in PnvChip and PnvCore, suggested by Cedric.
- Removed a stray cleanup hunk noticed by clg.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | target/ppc: Fix msgsnd for POWER8target/ | +44 | 1 reply | |
| 2/19 | ppc/pnv: Add pointer from PnvCPUState to PnvCorehw/ include/ | +4 | 0 replies | |
| 3/19 | ppc/pnv: Move timebase state into PnvCorehw/ include/ target/ +1 more | +49 | 0 replies | |
| 4/19 | target/ppc: Move SPR indirect registers into PnvCoreinclude/ target/ target/ +1 more | +39 | 0 replies | |
| 5/19 | ppc/pnv: use class attribute to limit SMT threads for different machineshw/ include/ | +10 | 0 replies | |
| 6/19 | ppc/pnv: Extend chip_pir class method to TIR as wellhw/ hw/ include/ | +64 | 0 replies | |
| 7/19 | ppc: Add a core_index to CPUPPCState for SMT vCPUshw/ hw/ target/ | +11 | 0 replies | |
| 8/19 | target/ppc: Add helpers to check for SMT sibling threadstarget/ target/ target/ +2 more | +30 | 0 replies | |
| 9/19 | ppc: Add has_smt_siblings property to CPUPPCStatehw/ hw/ target/ | +14 | 0 replies | |
| 10/19 | ppc/pnv: Add a big-core mode that joins two regular coreshw/ hw/ include/ +2 more | +78 | 0 replies | |
| 11/19 | ppc/pnv: Add allow for big-core differences in DT generationhw/ | +35 | 1 reply | |
| 12/19 | ppc/pnv: Implement big-core PVR for Power9/10hw/ | +4 | 0 replies | |
| 13/19 | ppc/pnv: Implement Power9 CPU core thread state indirect registertarget/ | +17 | 1 reply | |
| 14/19 | ppc/pnv: Add POWER10 ChipTOD quirk for big-corehw/ hw/ include/ +2 more | +25 | 1 reply | |
| 15/19 | ppc/pnv: Add big-core machine propertyhw/ | +45 | 1 reply | |
| 16/19 | system/cpus: Add cpu_pause() functioninclude/ system/ | +25 | 0 replies | |
| 17/19 | ppc/pnv: Add a CPU nmi and resume functionhw/ include/ | +15 | 0 replies | |
| 18/19 | ppc/pnv: Implement POWER10 PC xscom registers for direct controlshw/ include/ | +87 | 0 replies | |
| 19/19 | ppc/pnv: Add an LPAR per core machine optionhw/ hw/ include/ +3 more | +52 | 1 reply |
Reviews trailers per patch
16 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Cédric Le Goater | Harsh Prateek Bora | Philippe Mathieu-Daudé | Peter Xu |
|---|---|---|---|---|
| 1/19 | R-b | |||
| 2/19 | R-b | R-b | ||
| 3/19 | R-b | |||
| 4/19 | ||||
| 5/19 | R-b | R-b | ||
| 6/19 | R-b | |||
| 7/19 | R-b | |||
| 8/19 | R-b | |||
| 9/19 | R-b | |||
| 10/19 | ||||
| 11/19 | R-b | |||
| 12/19 | R-b | |||
| 13/19 | R-b | |||
| 14/19 | R-b | |||
| 15/19 | R-b | |||
| 16/19 | R-b | R-b | ||
| 17/19 | R-b | |||
| 18/19 | ||||
| 19/19 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 00/19] ppc/pnv: Better big-core model, lpar-per-core, PC unit
Primary motivation for this series is to improve big-core support.
This also fixes POWER8 SMT running Linux with the msgsnd fix and setting lpar-per-core mode (which is always true on POWER8).
Since v2:
- Converted big-core, lpar-per-core, and big-core tb quirk to object properties APIs in PnvChip and PnvCore, suggested by Cedric.
- Removed a stray cleanup hunk noticed by clg.
Since v1:
- Remove chip->pnv_machine pointer addition.
- Split cpu_pause() function into its own patch.
- Remove the _CORE_ID macro.
- Add has_lpar_per_thread machine class attribute to initialize the lpar mode to per-core on POWER8 machines instead of testing presence of machine state property.
Since rfc:
- Fixed POWER8 SMT so it doesn't have to be disabled.
- Fixed inadvertent spapr SMT bug.
- Renamed PnvCPUState.core pointer to pnv_core. (Harsh)
- Moved where it is initialised (clg)
- Avoided most qdev_get_machine() calls by adding a PnvMachineState pointer from PnvChip, new patch 3 (clg).
- Rename TB state to use camel case (Harsh and clg)
- Add comment to explain SPRC/SPRD is only accessed with powernv.
- Use mc->desc for error messages and avoid splitting machine init handlers (Harsh).
- Add max_smt_threads class attribute to avoid duplicating checks (clg)
- Rename processor_id() class method to get_pir_tir (Harsh and clg)
- Add a comment for get_pir_tir() (clg)
- Allow get_pir_tir() to be passed NULL pointers to avoid dummy pir/tir variables (Harsh)
- Move the PPC_CPU_HAS_CORE_SIBLINGS macros to inline functions (clg)
- Invert them (test for single-thread rather than for siblings) because the callers read a little better that way (Harsh).
- Propagate lpar and big-core options down to chip and core levels rather than having to test machine (clg)
- Significantly split the big-core patch (clg).
- Rework big-core device-tree handling to simplify it (clg).
- Make new has_smt_siblings property bool (Harsh)
- Make the big-core timebase tod quirk a machine class property rather than machine state (Harsh).
Thanks,
Nick
Nicholas Piggin (19):
target/ppc: Fix msgsnd for POWER8
ppc/pnv: Add pointer from PnvCPUState to PnvCore ppc/pnv: Move timebase state into PnvCore
target/ppc: Move SPR indirect registers into PnvCore ppc/pnv: use class attribute to limit SMT threads for different
machines
ppc/pnv: Extend chip_pir class method to TIR as well
ppc: Add a core_index to CPUPPCState for SMT vCPUs target/ppc: Add helpers to check for SMT sibling threads
ppc: Add has_smt_siblings property to CPUPPCState ppc/pnv: Add a big-core mode that joins two regular cores ppc/pnv: Add allow for big-core differences in DT generation ppc/pnv: Implement big-core PVR for Power9/10
ppc/pnv: Implement Power9 CPU core thread state indirect register ppc/pnv: Add POWER10 ChipTOD quirk for big-core ppc/pnv: Add big-core machine property
system/cpus: Add cpu_pause() function
ppc/pnv: Add a CPU nmi and resume function
ppc/pnv: Implement POWER10 PC xscom registers for direct controls ppc/pnv: Add an LPAR per core machine option
include/hw/core/cpu.h | 8 + include/hw/ppc/pnv.h | 8 + include/hw/ppc/pnv_chip.h | 6 +- include/hw/ppc/pnv_core.h | 31 ++++ target/ppc/cpu.h | 45 ++--- hw/ppc/pnv.c | 310 ++++++++++++++++++++++++++++------- hw/ppc/pnv_chiptod.c | 7 +- hw/ppc/pnv_core.c | 127 +++++++++++++- hw/ppc/spapr_cpu_core.c | 16 +- system/cpus.c | 30 ++-- target/ppc/cpu_init.c | 26 +-- target/ppc/excp_helper.c | 69 ++++---- target/ppc/misc_helper.c | 104 ++++++------ target/ppc/timebase_helper.c | 82 ++++----- 14 files changed, 620 insertions(+), 249 deletions(-)
Signature · 1 line
2.45.1