eth: bnxt: use the new RSS API
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first
v2 from the cover letter
- move "lost context" helper to common.c to avoid build problems when ethtool-nl isn't enabled
- add a note about the counter proposal in the commit message
- move key_off to the end, under the private label (hiding from kdoc)
- remove bnxt_get_max_rss_ctx_ring()
- switch from sizeof(u32) to sizeof(*indir_tbl)
- add a sentence to the commit msg
- store a pointer to struct ethtool_rxfh_param instead of adding the ethtool_rxfh_priv_context() helper
v1: https://lore.kernel.org/all/[email protected]/
Patches in v1 All 11 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | net: ethtool: let drivers remove lost RSS contextsinclude/ net/ | +16 | 0 replies | Applied |
| 2/11 | net: ethtool: let drivers declare max size of RSS indir table and keyinclude/ net/ | +44 | 0 replies | Applied |
| 3/11 | eth: bnxt: allow deleting RSS contexts when the device is downdrivers/ drivers/ | +10 | 0 replies | Applied |
| 4/11 | eth: bnxt: move from .set_rxfh to .create_rxfh_context and friendsdrivers/ drivers/ | +75 | 0 replies | Applied |
| 5/11 | eth: bnxt: remove rss_ctx_bmapdrivers/ drivers/ drivers/ | +2 | 0 replies | Applied |
| 6/11 | eth: bnxt: depend on core cleaning up RSS contextsdrivers/ drivers/ drivers/ | +6 | 0 replies | Applied |
| 7/11 | eth: bnxt: use context priv for struct bnxt_rss_ctxdrivers/ drivers/ drivers/ | +9 | 0 replies | Applied |
| 8/11 | eth: bnxt: use the RSS context XArray instead of the local listdrivers/ drivers/ drivers/ | +26 | 0 replies | Applied |
| 9/11 | eth: bnxt: pad out the correct indirection tabledrivers/ | +1 | 0 replies | Applied |
| 10/11 | eth: bnxt: bump the entry size in indir tables to u32drivers/ drivers/ drivers/ | +9 | 0 replies | Applied |
| 11/11 | eth: bnxt: use the indir table from ethtool contextdrivers/ drivers/ drivers/ | +29 | 0 replies | Applied |
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Pavan Chebbi |
|---|---|
| Series | R-b |
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 00/11] eth: bnxt: use the new RSS API
Convert bnxt from using the set_rxfh API to separate create/modify/remove callbacks.
Two small extensions to the core APIs are necessary:
- the ability to discard contexts if for some catastrophic reasons device can no longer provide them;
- the ability to reserve space in the context for RSS table growth.
The driver is adjusted to store indirection tables on u32 to make it easier to use core structs directly.
With that out of the way the conversion is fairly straightforward.
Since the opposition to discarding contexts was relatively mild and its what bnxt does already, I'm sticking to that. We may very well need to revisit that at a later time.
v2:
- move "lost context" helper to common.c to avoid build problems when ethtool-nl isn't enabled
- add a note about the counter proposal in the commit message
- move key_off to the end, under the private label (hiding from kdoc)
- remove bnxt_get_max_rss_ctx_ring()
- switch from sizeof(u32) to sizeof(*indir_tbl)
- add a sentence to the commit msg
- store a pointer to struct ethtool_rxfh_param instead of adding the ethtool_rxfh_priv_context() helper
v1: https://lore.kernel.org/all/[email protected]/
Jakub Kicinski (11):
net: ethtool: let drivers remove lost RSS contexts
net: ethtool: let drivers declare max size of RSS indir table and key
eth: bnxt: allow deleting RSS contexts when the device is down
eth: bnxt: move from .set_rxfh to .create_rxfh_context and friends
eth: bnxt: remove rss_ctx_bmap
eth: bnxt: depend on core cleaning up RSS contexts
eth: bnxt: use context priv for struct bnxt_rss_ctx
eth: bnxt: use the RSS context XArray instead of the local list
eth: bnxt: pad out the correct indirection table
eth: bnxt: bump the entry size in indir tables to u32
eth: bnxt: use the indir table from ethtool context
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 126 +++++-------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 17 +- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 165 ++++++++++-------- include/linux/ethtool.h | 20 +-- net/ethtool/common.c | 14 ++ net/ethtool/ioctl.c | 46 +++-- 6 files changed, 194 insertions(+), 194 deletions(-)
Signature · 1 line
2.45.2