Skip to content

KVM: arm64: fix warnings in W=1 build

Sebastian Ott kvmarm linux-arm-kernel lkml 2 versions – Applied

Status from this message: Applied to kvmarm/fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v13 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3KVM: arm64: fix override-init warnings in W=1 buildsarch/arm64/kvm/Makefile arch/arm64/kvm/hyp/nvhe/Makefile arch/arm64/kvm/hyp/vhe/Makefile+7 -00 replies
2/3KVM: arm64: fix kdoc warnings in W=1 buildsarch/arm64/kvm/arm.c arch/arm64/kvm/vgic/vgic-irqfd.c arch/arm64/kvm/vgic/vgic-its.c +1 more+17 -110 replies
3/3KVM: arm64: vgic: fix unexpected unlock sparse warningsarch/arm64/kvm/vgic/vgic.c arch/arm64/kvm/vgic/vgic.h+2 -20 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc Zyngier
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build

Building arch/arm64/kvm/ with W=1 spills out a lot of warnings. When changing stuff I try to use as much tooling as possible to make sure that I don't screw up - having a clean baseline imho helps with that.

With the first 2 patches applied make W=1 arch/arm64/kvm/ runs without warnings for me (fedora userspace, upstream linux after kvm merge). Patch 3 gets rid of sparse lock warnings in arch/arm64/kvm/vgic/.

Patch 1 now just adds -Wno-override-init to the cflags of the affected files. Alternatives would be to add this to the whole subdir or reintroduce the flag for higher warn levels..

Sebastian Ott (3):
KVM: arm64: fix override-init warnings in W=1 builds
KVM: arm64: fix kdoc warnings in W=1 builds
KVM: arm64: vgic: fix unexpected unlock sparse warnings

 arch/arm64/kvm/Makefile          |  3 +++
 arch/arm64/kvm/arm.c             |  1 +
 arch/arm64/kvm/hyp/nvhe/Makefile |  2 ++
 arch/arm64/kvm/hyp/vhe/Makefile  |  2 ++
 arch/arm64/kvm/vgic/vgic-irqfd.c |  7 ++++---
 arch/arm64/kvm/vgic/vgic-its.c   | 18 +++++++++++-------
 arch/arm64/kvm/vgic/vgic-v3.c    |  2 +-
 arch/arm64/kvm/vgic/vgic.c       |  2 +-
 arch/arm64/kvm/vgic/vgic.h       |  2 +-
 9 files changed, 26 insertions(+), 13 deletions(-)
Signature · 1 line
2.42.0