Skip to content

drm/probe-helpers: Work around multi-outputs-per-CRTC problem

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/probe-helper: Call connector detect functions in single helperdrivers/gpu/drm/drm_probe_helper.c+17 -161 reply
2/7drm/probe-helper: Optionally report single connected output per CRTCdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_probe_helper.c include/drm/drm_connector.h +1 more+123 -04 replies
3/7drm/ast: Set connector prioritiesdrivers/gpu/drm/ast/ast_mode.c+3 -00 replies
4/7drm/ast: Remove struct ast_bmc_connectordrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+6 -570 replies
5/7drm/ast: Support ASTDP and VGA at the same timedrivers/gpu/drm/ast/ast_main.c+1 -11 reply
6/7drm/mgag200: Set connector prioritiesdrivers/gpu/drm/mgag200/mgag200_g200eh.c drivers/gpu/drm/mgag200/mgag200_g200eh3.c drivers/gpu/drm/mgag200/mgag200_g200er.c +4 more+14 -00 replies
7/7drm/mgag200: Remove struct mgag200_bmc_connectordrivers/gpu/drm/mgag200/mgag200_bmc.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200eh.c +6 more+13 -540 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchMaxime RipardShixiong Ou
1/7A-b
2/7
3/7
4/7
5/7T-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] drm/probe-helpers: Work around multi-outputs-per-CRTC problem

Old or simple hardware only supports a single CRTC with multiple conenctoed outputs. This breaks most userspace compositors, which only support a single output per CRTC. This currently happens with ast and mgag200 drivers. The drivers contain a work around that dynamically disables all but one connected output.

Patches 1 and 2 push the workaround into probe helpers and make it configurable in the kernel config. For each connector, the driver needs to specify a bitmask of connectors with higher priority. If one of them is connected, the connector at hand is always reported as disconnected. Connectors without priority bitmask as not affected.

Patches 3 to 5 update and simplify the ast drivers. The new workaround now allows to have multiple physical conenctors in ast. So patch 5 finally allows VGA and DisplayPort on the same device.

Patches 6 and 7 update mgag200.

Any future driver that exposes the same problem as ast and mgag200 can simply hook into the workaround. Hopefully userspace can be fixed at some point.

Thomas Zimmermann (7):
drm/probe-helper: Call connector detect functions in single helper drm/probe-helper: Optionally report single connected output per CRTC drm/ast: Set connector priorities
drm/ast: Remove struct ast_bmc_connector
drm/ast: Support ASTDP and VGA at the same time drm/mgag200: Set connector priorities
drm/mgag200: Remove struct mgag200_bmc_connector

 drivers/gpu/drm/Kconfig                   |  15 +++
 drivers/gpu/drm/ast/ast_drv.h             |  17 +--
 drivers/gpu/drm/ast/ast_main.c            |   2 +-
 drivers/gpu/drm/ast/ast_mode.c            |  49 ++------
 drivers/gpu/drm/drm_probe_helper.c        | 137 +++++++++++++++++++---
 drivers/gpu/drm/mgag200/mgag200_bmc.c     |  44 +------
 drivers/gpu/drm/mgag200/mgag200_drv.h     |   9 +-
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200se.c  |   4 +-
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |   4 +-
 include/drm/drm_connector.h               |   2 +
 include/drm/drm_probe_helper.h            |   2 +
 16 files changed, 177 insertions(+), 128 deletions(-)
Signature · 1 line
2.45.2