Skip to content

Fix xtables-monitor rule printing, partially RFC

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8xtables-monitor: Proper re-init for rule's familyiptables/xtables-monitor.c+2 -00 replies
2/8xtables-monitor: Flush stdout after all lines of outputiptables/xtables-monitor.c+1 -10 replies
3/8xtables-monitor: Align builtin chain and table outputiptables/xtables-monitor.c+2 -10 replies
4/8xtables-monitor: Support arptables chain eventsiptables/xtables-monitor.c+3 -00 replies
5/8tests: shell: New xtables-monitor testiptables/tests/shell/testcases/nft-only/0012-xtables-monitor_0+149 -00 replies
6/8xtables-monitor: Fix for ebtables rule eventsiptables/tests/shell/testcases/nft-only/0012-xtables-monitor_0 iptables/xtables-monitor.c+9 -90 replies
7/8xtables-monitor: Ignore ebtables policy rules unless tracingiptables/nft.c iptables/nft.h iptables/tests/shell/testcases/nft-only/0012-xtables-monitor_0 +1 more+11 -100 replies
8/8xtables-monitor: Print commands instead of -4/-6/-0 flagsiptables/tests/shell/testcases/nft-only/0012-xtables-monitor_0 iptables/xtables-monitor.c+50 -560 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [iptables PATCH 0/8] Fix xtables-monitor rule printing, partially RFC

The patches in this series progress from fixes to features, and for the last two I'm not sure they are acceptable as-is: Patch 7 is not entirely complete, one should follow-up printing ebtables policy rules like builtin chain policies in traces but it requires quite some code churn. Patch 8 changes output of both events and traces, thus might break existing scripts parsing xtables-monitor output.

Phil Sutter (8):
xtables-monitor: Proper re-init for rule's family
xtables-monitor: Flush stdout after all lines of output
xtables-monitor: Align builtin chain and table output
xtables-monitor: Support arptables chain events
tests: shell: New xtables-monitor test
xtables-monitor: Fix for ebtables rule events
xtables-monitor: Ignore ebtables policy rules unless tracing
xtables-monitor: Print commands instead of -4/-6/-0 flags

 iptables/nft.c                                |   2 +-
 iptables/nft.h                                |   1 +
 .../testcases/nft-only/0012-xtables-monitor_0 | 139 ++++++++++++++++++
 iptables/xtables-monitor.c                    |  74 ++++++----
 4 files changed, 183 insertions(+), 33 deletions(-)
 create mode 100755 iptables/tests/shell/testcases/nft-only/0012-xtables-monitor_0
Signature · 1 line
2.43.0