Skip to content

drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE

Jocelyn Falempe dri-devel linux-fbdev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/panic: Add drm_panic_is_enabled()drivers/gpu/drm/drm_panic.c include/drm/drm_panic.h+22 -07 replies
2/3fbcon: Add an option to disable fbcon in panic.drivers/gpu/drm/drm_fb_helper.c drivers/video/fbdev/core/fbcon.c include/linux/fb.h+9 -13 replies
3/3drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLEdrivers/gpu/drm/Kconfig+1 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez CanillasDaniel Vetter
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE

When proposing to enable DRM_PANIC on Fedora, some users raised concern about the need to disable VT_CONSOLE.
So this is my new attempt to avoid fbcon/vt_console to overwrite the panic screen.
This time it doesn't involve any locking, so it should be safe.
I added a skip_panic option in struct fb_info, and check if this option and the panic_cpu are set in fb_is_inactive(), to prevent any framebuffer operation. Also skip_panic is only true if the drm driver supports drm_panic, so you will still get the VT panic info on drivers that don't have drm_panic support yet.

Jocelyn Falempe (3):
drm/panic: Add drm_panic_is_enabled()
fbcon: Add an option to disable fbcon in panic. drm/panic: Remove build time dependency with FRAMEBUFFER_CONSOLE

 drivers/gpu/drm/Kconfig          |  2 +-
 drivers/gpu/drm/drm_fb_helper.c  |  2 ++
 drivers/gpu/drm/drm_panic.c      | 20 ++++++++++++++++++++
 drivers/video/fbdev/core/fbcon.c |  7 ++++++-
 include/drm/drm_panic.h          |  2 ++
 include/linux/fb.h               |  1 +
 6 files changed, 32 insertions(+), 2 deletions(-)

base-commit: a237f217bad50c381773da5b00442710d1449098

Signature · 1 line
2.45.2