Skip to content

nvme: restrict authentication to the admin queue

Hannes Reinecke linux-nvme 3 versions – Applied

Status from this message: applied to nvme-6.16.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesApplied
  2. v22 patches 6 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes to v2 from the cover letter

- Include reviews from Sagi
- Drop the configfs attribute

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2nvmet: Authenticate on admin queue onlydrivers/nvme/target/auth.c drivers/nvme/target/fabrics-cmd.c+8 -51 reply
2/2nvme: Do not re-authenticate queues with no prior authenticationdrivers/nvme/host/auth.c+22 -80 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSagi Grimberg
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 0/2] nvme: restrict authentication to the admin queue

Hi all,

with secure concatenation the spec got more explicit to state that it would be perfectly fine to implement authentication on the admin queue only. But once a partner implemented that he found that re-authentication was failing as we continue to start authentication on all queues.
So these two patches implement this functionalify, the first one to modify the target to request authentication on the admin queue only, and the second one to the host to not start authentication on I/O queues during re-authentication if it wasn't requested initially.

As usual, comments and reviews are welcome.

Changes to the original submission:
- Rebased to nvme-6.14

Changes to v2:
- Include reviews from Sagi
- Drop the configfs attribute

Hannes Reinecke (2):
nvmet: Authenticate on admin queue only
nvme: Do not re-authenticate queues with no prior authentication

 drivers/nvme/host/auth.c          | 30 ++++++++++++++++++++++--------
 drivers/nvme/target/auth.c        |  9 ++++++---
 drivers/nvme/target/fabrics-cmd.c |  4 ++--
 3 files changed, 30 insertions(+), 13 deletions(-)
Signature · 1 line
2.35.3