Skip to content

drm/ast: Fix DP hotplugging and clean up

Thomas Zimmermann dri-devel stable 1 version Applied

Status from this message: I merged this patch into drm-misc-fixes.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5drm/ast: astdp: Wake up during connector status detectiondrivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+35 -22 replies
2/5drm/ast: astdp: Test firmware status once during probingdrivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c +2 more+23 -322 replies
3/5drm/ast: astdp: Only test HDP state in ast_astdp_is_connected()drivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_reg.h+4 -111 reply
4/5drm/ast: astdp: Perform link training during atomic_enabledrivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c +1 more+26 -251 reply
5/5drm/ast: astdp: Clean up EDID readingdrivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_reg.h+44 -611 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchShixiong OuJocelyn Falempe
1/5R-b
2/5T-b R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] drm/ast: Fix DP hotplugging and clean up

Here are a number of updates for ast's ASTDP transmitter code.

So far the ast driver required the DisplayPort to be connected at boot. Later detection was not supported. Re-connecting the cable was also not supported. Once atomic_disable powered off the physical ASTDP connector, there was no way of detecting a conencted display. Patch 1 makes Hot Plug Detection work. If ncesessary, the connector's detect helper powers up the physical connector to read the HPD status.

That's a good oportunity to clean up ast's whole detection code for ASTDP transmitters. So patch 2 to 4 remove duplicated status tests throughout the ASTDP code.

Patch 5 simplified the code for reading the display's EDID data from the firmware.

Tested on AST2600 hardware with an ASTDP transmitter.

Thomas Zimmermann (5):
drm/ast: astdp: Wake up during connector status detection drm/ast: astdp: Test firmware status once during probing drm/ast: astdp: Only test HDP state in ast_astdp_is_connected() drm/ast: astdp: Perform link training during atomic_enable drm/ast: astdp: Clean up EDID reading

 drivers/gpu/drm/ast/ast_dp.c   | 186 +++++++++++++++------------------
 drivers/gpu/drm/ast/ast_drv.h  |   4 +-
 drivers/gpu/drm/ast/ast_main.c |   6 +-
 drivers/gpu/drm/ast/ast_mode.c |  31 +++++-
 drivers/gpu/drm/ast/ast_post.c |   2 +-
 drivers/gpu/drm/ast/ast_reg.h  |  22 ++--
 6 files changed, 126 insertions(+), 125 deletions(-)
Signature · 1 line
2.45.2