Skip to content

net: dsa: microchip: ksz8795: add Wake on LAN support

[email protected] linux-devicetree lkml netdev 6 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyApplied 6/6
  2. v56 patches 2 repliesSuperseded
  3. v45 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches6 repliesSuperseded
v25 patches7 repliesSuperseded
v14 patches7 repliesSuperseded

Changes in v6 from the cover letter

- patch 6/6: use GENMASK macro in dedicated mask macro instead of inline

Patches in v6 All 6 applied

#Subject and filesSizeRepliesApplied
1/6dt-bindings: net: dsa: microchip: add microchip,pme-active-high flagDocumentation/devicetree/bindings/net/dsa/microchip,ksz.yaml+5 -00 repliesApplied
2/6net: dsa: microchip: move KSZ9477 WoL functions to ksz_commondrivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz9477.h drivers/net/dsa/microchip/ksz9477_reg.h +2 more+200 -1980 repliesApplied
3/6net: dsa: microchip: generalize KSZ9477 WoL functions at ksz_commondrivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c drivers/net/dsa/microchip/ksz_common.h+81 -780 repliesApplied
4/6net: dsa: microchip: add WoL support for KSZ87xx familydrivers/net/dsa/microchip/ksz8.h drivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz_common.c +1 more+119 -80 repliesApplied
5/6net: dsa: microchip: fix KSZ87xx family structure wrt the datasheetdrivers/net/dsa/microchip/ksz_common.c+43 -80 repliesApplied
6/6net: dsa: microchip: fix tag_ksz egress mask for KSZ8795 familynet/dsa/tag_ksz.c+4 -21 replyApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)Oleksij RempelArun Ramadoss
1/6R-b R-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH net-next v6 0/6] net: dsa: microchip: ksz8795: add Wake on LAN support

From: Pieter Van Trappen <[email protected]>

Add WoL support for KSZ8795 family of switches. This code was tested with a KSZ8794 chip.

Strongly based on existing KSZ9477 code which has now been moved to ksz_common instead of duplicating, as proposed during the review of the v1 version of this patch.

In addition to the device-tree addition and the actual code, there's two additional patches that fix some bugs found when further testing DSA with this KSZ8794 chip.

---
v6:
- patch 6/6: use GENMASK macro in dedicated mask macro instead of inline

v5: https://lore.kernel.org/netdev/[email protected]/
- patch 5/6: split off DSA tag_ksz fix to separate patch 6/6

v4: https://lore.kernel.org/netdev/[email protected]/
- patch 4/5: rename KSZ8795* macros to KSZ87XX*
- patch 5/5: rename ksz8_dev_ops to ksz88x3_dev_ops
- patch 5/5: additional DSA tag_ksz fix

v3: https://lore.kernel.org/netdev/[email protected]/
- ensure each patch separately compiles & works
- additional return value checks where possible
- drop v2 patch 5/5 (net: dsa: microchip: check erratum workaround through indirect register read)
- add new patch 5/5 that fixes KSZ87xx bugs wrt datasheet

v2: https://lore.kernel.org/netdev/[email protected]/
- generalize instead of duplicate, much improved
- variable declaration reverse Christmas tree
- ksz8_handle_global_errata: return -EIO in case of indirect write failure
- ksz8_ind_read8/write8: document functions
- ksz8_handle_wake_reason: no need for additional write to clear
- fix wakeup_source origin comments
v1: https://lore.kernel.org/netdev/[email protected]/

Pieter Van Trappen (6):
dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag
net: dsa: microchip: move KSZ9477 WoL functions to ksz_common
net: dsa: microchip: generalize KSZ9477 WoL functions at ksz_common
net: dsa: microchip: add WoL support for KSZ87xx family
net: dsa: microchip: fix KSZ87xx family structure wrt the datasheet
net: dsa: microchip: fix tag_ksz egress mask for KSZ8795 family

 .../bindings/net/dsa/microchip,ksz.yaml       |   5 +
 drivers/net/dsa/microchip/ksz8.h              |   3 +
 drivers/net/dsa/microchip/ksz8795.c           |  94 +++++-
 drivers/net/dsa/microchip/ksz9477.c           | 197 +------------
 drivers/net/dsa/microchip/ksz9477.h           |   5 -
 drivers/net/dsa/microchip/ksz9477_reg.h       |  12 -
 drivers/net/dsa/microchip/ksz_common.c        | 271 ++++++++++++++++--
 drivers/net/dsa/microchip/ksz_common.h        |  31 +-
 net/dsa/tag_ksz.c                             |   6 +-
 9 files changed, 391 insertions(+), 233 deletions(-)

base-commit: dd1bf9f9df156b43e5122f90d97ac3f59a1a5621

Signature · 1 line
2.43.0