Skip to content

Add support for cpu event term

Ian Rogers linux-perf-users lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 1 replyIn review
  2. v54 patches 6 repliesSuperseded
  3. v44 patches 5 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches4 repliesSuperseded
v26 patches27 repliesSuperseded
v16 patches0 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4libperf cpumap: Add ability to create CPU from a single CPU numbertools/lib/perf/cpumap.c tools/lib/perf/include/perf/cpumap.h+12 -00 replies
2/4perf stat: Use counter cpumask to skip zero valuestools/perf/util/stat-display.c+13 -80 replies
3/4perf parse-events: Set is_pmu_core for legacy hardware eventstools/perf/util/parse-events.c+23 -140 replies
4/4perf parse-events: Add "cpu" term to set the CPU an event is recorded ontools/perf/Documentation/perf-list.txt tools/perf/util/evsel_config.h tools/perf/util/parse-events.c +3 more+76 -170 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchKan Liang
SeriesT-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] Add support for cpu event term

Being able to set the cpu mask per event was discussed in the context of a sysfs event.cpus file is discussed here:
https://lore.kernel.org/lkml/CAP-5=fXXuWchzUK0n5KTH8kamr=DQoEni+bUoo8f-4j8Y+eMBg@mail.gmail.com/
Ultimately Kan preferred to have multiple PMUs with a cpumask each rather than an event.cpus file per event. It is still useful to have the cpu event term and so the sysfs part of the original patch series is dropped.

v6: Purely a rebase.
v5: Purely a rebase.
v4: Add the stat-display output change for zero counters Namhyung
requested as part of the series:
https://lore.kernel.org/lkml/[email protected]/
This skips zero values for CPUs not in the evsel's cpumask rather than the evsel's PMU's cpumask.
v3: Drop sysfs event.cpus file support patch from series. Reference
to using cpu to modify uncore events is dropped from the commit message. Reference counting issues on the cpumap are addressed.
v2: Add support for multiple cpu terms on an event that are
merged. For example, an event of "l1d-misses/cpu=4,cpu=5/" will now be opened on both CPU 4 and 5 rather than just CPU 4.

Ian Rogers (4):
libperf cpumap: Add ability to create CPU from a single CPU number perf stat: Use counter cpumask to skip zero values
perf parse-events: Set is_pmu_core for legacy hardware events perf parse-events: Add "cpu" term to set the CPU an event is recorded
on

 tools/lib/perf/cpumap.c                |  10 +++
 tools/lib/perf/include/perf/cpumap.h   |   2 +
 tools/perf/Documentation/perf-list.txt |   9 ++
 tools/perf/util/evsel_config.h         |   1 +
 tools/perf/util/parse-events.c         | 113 ++++++++++++++++++-------
 tools/perf/util/parse-events.h         |   3 +-
 tools/perf/util/parse-events.l         |   1 +
 tools/perf/util/pmu.c                  |   3 +-
 tools/perf/util/stat-display.c         |  21 +++--
 9 files changed, 124 insertions(+), 39 deletions(-)
Signature · 1 line
2.49.0.504.g3bcea36a83-goog