Skip to content

volatile-binds: Mitigate workdir cleanup issues

[email protected] openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2volatile-binds: Do not create workdir if OverlayFS is disabledmeta/recipes-core/volatile-binds/files/mount-copybind+3 -10 replies
2/2volatile-binds: Remove workdir if OverlayFS failsmeta/recipes-core/volatile-binds/files/mount-copybind+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] volatile-binds: Mitigate workdir cleanup issues

From: Ricardo Simoes <[email protected]>

The recipe volatile-binds relies on the mount-copybind script to create volatile mount points. In commit [1], the script was modified to use OverlayFS as the primary mount strategy. If OverlayFS fails, it falls back to an old-school bind mount.

To meet the requirements of OverlayFS, the script now unconditionally creates a workdir. However, the newly created directory is left in place in case the bind mount strategy is used.

Commit [2] introduced support for avoiding the OverlayFS strategy by setting the MOUNT_COPYBIND_AVOID_OVERLAYFS environment variable. However, the workdir is unconditionally created.

This patch series addresses both problems. Firstly, it only creates the workdir if the MOUNT_COPYBIND_AVOID_OVERLAYFS variable is not asserted. Secondly, it unconditionally attempts to remove the workdir in case a bind mount is done.

[1] b4976f3cf8cd028f165100b67867adb862da4d7f
volatile-binds: use overlayfs if available

[2] a8e7dca69054798b1c9843a0de889cef3e261c4f
mount-copybind: add MOUNT_COPYBIND_AVOID_OVERLAYFS env var to skip OverlayFS

Ricardo Simoes (2):
volatile-binds: Do not create workdir if OverlayFS is disabled
volatile-binds: Remove workdir if OverlayFS fails

 meta/recipes-core/volatile-binds/files/mount-copybind | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1