Skip to content

Refactor to unify connect failure code path

James Prestwood iwd 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest11 patches 1 replyIn review

Changes in v2 from the cover letter

* Combined two earlier patch sets (autotests and netdev patch)
* Call netdev_disconnected() rather than handle the logic manually
* Add new NETDEV_RESULT_DISCONNECTED to cover any disconnect issued by the AP during the connection stage. This cover the 4-way handshake or key setting, or anything in between.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11station: print unknown channel number in neighbor reportsrc/station.c+1 -10 replies
2/11netdev: add NETDEV_RESULT_DISCONNECTEDsrc/netdev.h src/p2p.c src/station.c+4 -00 replies
3/11station: handle NETDEV_RESULT_DISCONNECTEDsrc/station.c+18 -90 replies
4/11station: update logic for handshake failuresrc/station.c+7 -10 replies
5/11netdev: handle disconnect event during a connectionsrc/netdev.c+5 -140 replies
6/11eapol: move HANDSHAKE_STARTED_EVENT to eapol_start()src/eapol.c+2 -20 replies
7/11station: add handshake-started debug eventsrc/station.c+1 -00 replies
8/11auto-t: add clear_events() to IWD classautotests/util/iwd.py+6 -00 replies
9/11auto-t: add reason/test arguments to hostapd deauthenticateautotests/util/hostapd.py+5 -10 replies
10/11auto-t: Add deauth during the 4-way handshake testautotests/testPSK-roam/disconnect_during_handshake_test.py autotests/testPSK-roam/ft-psk-ccmp-1.conf autotests/testPSK-roam/ft-psk-ccmp-2.conf +2 more+118 -30 replies
11/11auto-t: a few random autotest fixesautotests/testEncryptedProfiles/ssidCCMP.psk autotests/testPSK-roam/failed_roam_test.py autotests/testPSK-roam/roam_ap_disconnect_test.py+17 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/11] Refactor to unify connect failure code path

v2:
* Combined two earlier patch sets (autotests and netdev patch)
* Call netdev_disconnected() rather than handle the logic manually
* Add new NETDEV_RESULT_DISCONNECTED to cover any disconnect issued by the AP during the connection stage. This cover the 4-way handshake or key setting, or anything in between.

There are some additional unrelated patches, and more autotest fixes that were needed as a result of some prior changes

James Prestwood (11):
station: print unknown channel number in neighbor report
netdev: add NETDEV_RESULT_DISCONNECTED
station: handle NETDEV_RESULT_DISCONNECTED
station: update logic for handshake failure
netdev: handle disconnect event during a connection
eapol: move HANDSHAKE_STARTED_EVENT to eapol_start()
station: add handshake-started debug event
auto-t: add clear_events() to IWD class
auto-t: add reason/test arguments to hostapd deauthenticate
auto-t: Add deauth during the 4-way handshake test
auto-t: a few random autotest fixes

 autotests/testEncryptedProfiles/ssidCCMP.psk  |   3 +
 .../disconnect_during_handshake_test.py       | 112 ++++++++++++++++++
 autotests/testPSK-roam/failed_roam_test.py    |   3 +
 autotests/testPSK-roam/ft-psk-ccmp-1.conf     |   2 +-
 autotests/testPSK-roam/ft-psk-ccmp-2.conf     |   2 +-
 autotests/testPSK-roam/ft-psk-ccmp-3.conf     |   2 +-
 autotests/testPSK-roam/main.conf              |   3 +
 .../testPSK-roam/roam_ap_disconnect_test.py   |  12 +-
 autotests/util/hostapd.py                     |   6 +-
 autotests/util/iwd.py                         |   6 +
 src/eapol.c                                   |   4 +-
 src/netdev.c                                  |  19 +--
 src/netdev.h                                  |   2 +
 src/p2p.c                                     |   1 +
 src/station.c                                 |  39 ++++--
 15 files changed, 184 insertions(+), 32 deletions(-)
 create mode 100644 autotests/testPSK-roam/disconnect_during_handshake_test.py
Signature · 1 line
2.34.1