Skip to content

Expand available features on Qnap TS433

Heiko Stuebner linux-arm-kernel linux-rockchip lkml 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 2 repliesApplied
  2. v214 patches 5 repliesSuperseded
  3. v18 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- fix the two regulator node-names, I noticed after sending v2
- add Uwe's Tested-by tags
- fold in some of Uwe's suggestions:
- remove some phandles
- more comments to explain what is connected where
- handle the two RTCs in the system, though not by hacking around to disable the pmic-one, instead just make sure the real one stays the first rtc

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/14arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+21 -00 replies
2/14arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+9 -10 replies
3/14arm64: dts: rockchip: enable uart0 on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+8 -00 replies
4/14arm64: dts: rockchip: enable usb ports on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+105 -00 replies
5/14arm64: dts: rockchip: add stdout path on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+4 -00 replies
6/14arm64: dts: rockchip: enable sata1+2 on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+18 -00 replies
7/14arm64: dts: rockchip: add board-aliases for Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+7 -10 replies
8/14arm64: dts: rockchip: add hdd leds to Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+59 -00 replies
9/14arm64: dts: rockchip: enable the tsadc on the Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+6 -00 replies
10/14arm64: dts: rockchip: add gpio-keys to Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+29 -00 replies
11/14arm64: dts: rockchip: define cpu-supply on the Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+41 -00 replies
12/14arm64: dts: rockchip: add missing pmic information on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+226 -10 replies
13/14arm64: dts: rockchip: enable gpu on Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+5 -00 replies
14/14arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts+5 -00 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by.

PatchUwe Kleine-König
1/14T-b
2/14T-b
3/14T-b
4/14T-b
5/14T-b
6/14T-b
7/14T-b
8/14T-b
9/14T-b
10/14T-b
11/14T-b
12/14T-b
13/14T-b
14/14T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/14] Expand available features on Qnap TS433

Thanks to the nicely supported rk3568, the hardest part for adding things, is to pull things from the vendor-kernel and translating them to mainline standards.

This series allows the TS433 to use all 4 bays [0], wiggle some LEDs and access devices connected to all 3 usb ports.

The device runs stable now and might be usable for actual usage.

There is still a todo-list though:
- the ethernet mac address for the realtek chip seems correct, but the gmac0 interface currently uses a wrong one
- i2cdetect reports devices on i2c-1 on addresses 54,55,56,57 model_Q0B20_Q0B30_10_10.conf from the original rescue image labels them

    VPD_MB = I2C:0x54, VPD_BP = I2C:0x56

the meaning currently being unknown. Some eeprom maybe?
- The regulator tree is slightly dubious. Everthing seems to follow rk3568 reference designs, but especially the regulator labeled vcc3v3_sd seems to supply some PCIe functionality. So I guess the device's schematics will look quite different than the regulators added to the vendor devicetree.
- Quite a bit of functionality is provided by the MCU connected to uart0. According to the model.conf there should be fan-control, a number of additional LEDs (status,locate,usb?)

Thanks to Qnap engineers adding an easily accessible header for maskrom mode on the board, replacing the bootloader is also quite a breeze. A branch on top of today's u-boot master branch can be found on [1]. I'll submit that code to u-boot once I can cherry-pick the dts patches.

changes in v3:
- fix the two regulator node-names, I noticed after sending v2
- add Uwe's Tested-by tags
- fold in some of Uwe's suggestions:
- remove some phandles
- more comments to explain what is connected where
- handle the two RTCs in the system, though not by hacking around to disable the pmic-one, instead just make sure the real one stays the first rtc
changes in v2:
- add patches for tsadc, gpio-keys, cpu-supply, pmic, gpu and io-domains

[0] I only have two drives right now, but I tested both the internal sata connector as well as the PCIe connected sata controller in different combinations.
[1] https://github.com/mmind/u-boot-rockchip/tree/dev/qnap-ts433/v2024.07

Heiko Stuebner (14):
arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433
arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433
arm64: dts: rockchip: enable uart0 on Qnap-TS433
arm64: dts: rockchip: enable usb ports on Qnap-TS433
arm64: dts: rockchip: add stdout path on Qnap-TS433
arm64: dts: rockchip: enable sata1+2 on Qnap-TS433
arm64: dts: rockchip: add board-aliases for Qnap-TS433
arm64: dts: rockchip: add hdd leds to Qnap-TS433
arm64: dts: rockchip: enable the tsadc on the Qnap-TS433
arm64: dts: rockchip: add gpio-keys to Qnap-TS433
arm64: dts: rockchip: define cpu-supply on the Qnap-TS433
arm64: dts: rockchip: add missing pmic information on Qnap-TS433
arm64: dts: rockchip: enable gpu on Qnap-TS433
arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433

 .../boot/dts/rockchip/rk3568-qnap-ts433.dts   | 546 +++++++++++++++++-
 1 file changed, 543 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.2