Skip to content

ext4: fix incorrect tid assumptions

Luis Henriques (SUSE) linux-ext4 lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesApplied
  2. v14 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- [PATCH 1/4] set 'has_transaction' variable on each loop iteration
- [PATCH 3/4] dropped local variable 'is_last'; renamed 'is_first' to 'first_set' (including corresponding semantic adjustment)
- [PATCH 4/4] removed extra braces in statement

[1] https://lore.kernel.org/all/20240716095201.o7kkrhfdy2bps3rw@quack3/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit()fs/ext4/inode.c+7 -41 reply
2/4ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space()fs/jbd2/checkpoint.c+5 -20 replies
3/4ext4: fix incorrect tid assumption in jbd2_journal_shrink_checkpoint_list()fs/jbd2/checkpoint.c+5 -21 reply
4/4ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible()fs/ext4/fast_commit.c+11 -40 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJan Kara
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] ext4: fix incorrect tid assumptions

Hi

As discussed here [1], there are a few places in ext4 and jbd2 code where it is assumed that a tid of '0' is not valid. Which isn't true.

This small patchset tries to fix (hopefully!) all these places. Jan Kara had already identified the functions that needed to be fixed. I believe that the only other issue is the handling of sbi->s_fc_ineligible_tid.

Each patch in this series fixes a single function; the last one also fixes the sbi->s_fc_ineligible_tid handling.

Changes since v1:
- [PATCH 1/4] set 'has_transaction' variable on each loop iteration
- [PATCH 3/4] dropped local variable 'is_last'; renamed 'is_first' to 'first_set' (including corresponding semantic adjustment)
- [PATCH 4/4] removed extra braces in statement

[1] https://lore.kernel.org/all/20240716095201.o7kkrhfdy2bps3rw@quack3/

*** BLURB HERE ***

Luis Henriques (SUSE) (4):
ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit()
ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space()
ext4: fix incorrect tid assumption in
jbd2_journal_shrink_checkpoint_list()
ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible()

 fs/ext4/fast_commit.c | 15 +++++++++++----
 fs/ext4/inode.c       | 11 +++++++----
 fs/jbd2/checkpoint.c  | 14 ++++++++++----
 3 files changed, 28 insertions(+), 12 deletions(-)