Skip to content

notes: fix editor invocation regression

David Disseldorp git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 3 repliesIn review
  2. v12 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1notes: do not trigger editor when adding an empty notebuiltin/notes.c t/t3301-notes.sh+15 -123 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] notes: fix editor invocation regression

The following patch attempts to restore previous editor invocation behavior for empty notes, which was inadvertantly changed via 90bc19b3ae (notes.c: introduce '--separator=<paragraph-break>' option, 2023-05-27). A new regression test is included, which passes prior to 90bc19b3ae and after this fix.

Please cc me in any replies as I'm not subscribed.

Cheers, David

--

The following changes since commit ad57f148c6b5f8735b62238dda8f571c582e0e54:

Git 2.46-rc2 (2024-07-23 16:54:35 -0700)

are available in the Git repository at:

https://github.com/ddiss/git.git notes_empty_editor_add_v2

for you to fetch changes up to 63019aa2c7bbee5989944a990ca2c0229cef8ae2:

notes: do not trigger editor when adding an empty note (2024-07-29 13:22:26 +0200)

----------------------------------------------------------------
David Disseldorp (1):
notes: do not trigger editor when adding an empty note

 builtin/notes.c  | 22 ++++++++++------------
 t/t3301-notes.sh |  5 +++++
 2 files changed, 15 insertions(+), 12 deletions(-)