Skip to content

btrfs: fix relocation on RAID stripe-tree filesystems

Johannes Thumshirn linux-btrfs lkml 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240726-debug-f1fe805ea37b

Versions newest first

  1. v3 Latest5 patches 2 repliesIn review
  2. v25 patches 3 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Re-base onto for-next with folio->page conversion applied.
- Collected reviews.
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5btrfs: don't dump stripe-tree on lookup errorfs/btrfs/raid-stripe-tree.c+0 -20 replies
2/5btrfs: rename btrfs_io_stripe::is_scrub to rst_search_commit_rootfs/btrfs/bio.c fs/btrfs/raid-stripe-tree.c fs/btrfs/scrub.c +1 more+5 -50 replies
3/5btrfs: set rst_search_commit_root in case of relocationfs/btrfs/bio.c+2 -11 reply
4/5btrfs: don't readahead the relocation inode on RSTfs/btrfs/relocation.c+10 -41 reply
5/5btrfs: change RST lookup error message to debugfs/btrfs/raid-stripe-tree.c+1 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJosef BacikQu Wenruo
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] btrfs: fix relocation on RAID stripe-tree filesystems

When doing relocation on RST backed filesystems, there is a possibility of a scatter-gather list corruption.

See patch 4 for details.

CI Link: https://github.com/btrfs/linux/actions/runs/10143804038

---
Changes in v3:
- Re-base onto for-next with folio->page conversion applied.
- Collected reviews.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Change RST lookup error message to debug
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Johannes Thumshirn (5):
btrfs: don't dump stripe-tree on lookup error
btrfs: rename btrfs_io_stripe::is_scrub to rst_search_commit_root
btrfs: set rst_search_commit_root in case of relocation
btrfs: don't readahead the relocation inode on RST
btrfs: change RST lookup error message to debug

 fs/btrfs/bio.c              |  3 ++-
 fs/btrfs/raid-stripe-tree.c |  8 +++-----
 fs/btrfs/relocation.c       | 14 ++++++++++----
 fs/btrfs/scrub.c            |  2 +-
 fs/btrfs/volumes.h          |  2 +-
 5 files changed, 17 insertions(+), 12 deletions(-)

---
base-commit: 27d58e7d992b58ae7091270dc179e1dcbd6561f8
change-id: 20240726-debug-f1fe805ea37b

Best regards,

Signature · 1 line
Johannes Thumshirn <[email protected]>