Skip to content

nfsd: assorted clean-ups

NeilBrown linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nfsd: Don't pass all of rqst into rqst_exp_find()fs/nfsd/export.c fs/nfsd/export.h fs/nfsd/nfs4proc.c +1 more+35 -120 replies
2/6nfsd: Pass 'cred' instead of 'rqstp' to some functions.fs/nfsd/auth.c fs/nfsd/auth.h fs/nfsd/export.h +5 more+33 -270 replies
3/6nfsd: Move error code mapping to per-version xdr code.fs/nfsd/export.c fs/nfsd/nfs3xdr.c fs/nfsd/nfs4proc.c +6 more+91 -393 replies
4/6nfsd: use nfsd_v4client() in nfsd_breaker_owns_lease()fs/nfsd/nfs4state.c fs/nfsd/nfsd.h fs/nfsd/nfssvc.c+8 -90 replies
5/6nfsd: further centralize protocol version checks.fs/nfsd/nfsfh.c fs/nfsd/nfsfh.h fs/nfsd/vfs.c+9 -60 replies
6/6nfsd: move V4ROOT version check to nfsd_set_fh_dentry()fs/nfsd/nfsfh.c+7 -110 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJeff Layton
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] nfsd: assorted clean-ups

My recent series (that may not now be needed) to allow fh_verify() to not be given an rqstp pointer (instead taking the individual fields that it actually needs) exposed several opportunities for improving code cleanliness. This series provides just those.

I'm not convinced that the last 2 are a genuine improvement, but that follow a pattern set by earlier patches, and maybe they are a good idea.

There is some minor behavioural change in that some error codes are changed as described in patch 3.

Thanks,
NeilBrown

[PATCH 1/6] nfsd: Don't pass all of rqst into rqst_exp_find() [PATCH 2/6] nfsd: Pass 'cred' instead of 'rqstp' to some functions. [PATCH 3/6] nfsd: Move error code mapping to per-version xdr code. [PATCH 4/6] nfsd: use nfsd_v4client() in nfsd_breaker_owns_lease() [PATCH 5/6] nfsd: further centralize protocol version checks. [PATCH 6/6] nfsd: move V4ROOT version check to nfsd_set_fh_dentry()