Skip to content

soc: fsl: Add support for QUICC Engine TSA and QMC

Herve Codina linux-arm-kernel linux-devicetree linuxppc-dev lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest36 patches 39 repliesIn review
  2. v136 patches 4 repliesSuperseded

Changes in v2 from the cover letter

v1: https://lore.kernel.org/lkml/[email protected]/
- patch 7
Removed redundant sentences
Removed unneeded property names from property descriptions.

- patch 13
Fixed issue detected by a kernel test robot:
cast to smaller integer type 'enum tsa_version' from 'const void *'

- patch 23
Moved channel compatible string to the first item in the channel property list.

- patch 32
Added missing device.h header for devres_* function declarations (issue detected by kernel test robots).

- Other patches
No changes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/36soc: fsl: cpm1: qmc: Update TRNSYNC only in transparent modedrivers/soc/fsl/qe/qmc.c+14 -101 reply
2/36soc: fsl: cpm1: qmc: Enable TRNSYNC only when neededdrivers/soc/fsl/qe/qmc.c+11 -11 reply
3/36soc: fsl: cpm1: tsa: Fix tsa_write8()drivers/soc/fsl/qe/tsa.c+1 -11 reply
4/36soc: fsl: cpm1: tsa: Use BIT(), GENMASK() and FIELD_PREP() macrosdrivers/soc/fsl/qe/tsa.c+68 -591 reply
5/36soc: fsl: cpm1: tsa: Fix blank line and spacesdrivers/soc/fsl/qe/tsa.c+3 -41 reply
6/36soc: fsl: cpm1: tsa: Add missing spinlock commentdrivers/soc/fsl/qe/tsa.c+1 -11 reply
7/36dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controllerDocumentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-tsa.yaml include/dt-bindings/soc/qe-fsl,tsa.h+223 -02 replies
8/36soc: fsl: cpm1: tsa: Remove unused registers offset definitiondrivers/soc/fsl/qe/tsa.c+0 -91 reply
9/36soc: fsl: cpm1: tsa: Use ARRAY_SIZE() instead of hardcoded integer valuesdrivers/soc/fsl/qe/tsa.c+4 -41 reply
10/36soc: fsl: cpm1: tsa: Make SIRAM entries specific to CPM1drivers/soc/fsl/qe/tsa.c+46 -291 reply
11/36soc: fsl: cpm1: tsa: Introduce tsa_setup() and its CPM1 compatible versiondrivers/soc/fsl/qe/tsa.c+54 -391 reply
12/36soc: fsl: cpm1: tsa: Isolate specific CPM1 part from tsa_serial_{dis}connect()drivers/soc/fsl/qe/tsa.c+43 -601 reply
13/36soc: fsl: cpm1: tsa: Introduce tsa_versiondrivers/soc/fsl/qe/tsa.c+15 -11 reply
14/36soc: fsl: cpm1: tsa: Add support for QUICC Engine (QE) implementationdrivers/soc/fsl/qe/Kconfig drivers/soc/fsl/qe/tsa.c+319 -191 reply
15/36MAINTAINERS: Add QE files related to the Freescale TSA controllerMAINTAINERS+2 -01 reply
16/36soc: fsl: cpm1: tsa: Introduce tsa_serial_get_num()drivers/soc/fsl/qe/tsa.c drivers/soc/fsl/qe/tsa.h+39 -201 reply
17/36soc: fsl: cpm1: qmc: Rename QMC_TSA_MASKdrivers/soc/fsl/qe/qmc.c+4 -41 reply
18/36soc: fsl: cpm1: qmc: Use BIT(), GENMASK() and FIELD_PREP() macrosdrivers/soc/fsl/qe/qmc.c+72 -601 reply
19/36soc: fsl: cpm1: qmc: Fix blank line and spacesdrivers/soc/fsl/qe/qmc.c+4 -61 reply
20/36soc: fsl: cpm1: qmc: Remove unneeded parenthesisdrivers/soc/fsl/qe/qmc.c+4 -41 reply
21/36soc: fsl: cpm1: qmc: Fix 'transmiter' typodrivers/soc/fsl/qe/qmc.c+2 -21 reply
22/36soc: fsl: cpm1: qmc: Add missing spinlock commentdrivers/soc/fsl/qe/qmc.c+2 -21 reply
23/36dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controllerDocumentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml+197 -02 replies
24/36soc: fsl: cpm1: qmc: Introduce qmc_data structuredrivers/soc/fsl/qe/qmc.c+46 -231 reply
25/36soc: fsl: cpm1: qmc: Re-order probe() operationsdrivers/soc/fsl/qe/qmc.c+26 -281 reply
26/36soc: fsl: cpm1: qmc: Introduce qmc_init_resource() and its CPM1 versiondrivers/soc/fsl/qe/qmc.c+31 -161 reply
27/36soc: fsl: cpm1: qmc: Introduce qmc_{init,exit}_xcc() and their CPM1 versiondrivers/soc/fsl/qe/qmc.c+45 -211 reply
28/36soc: fsl: cpm1: qmc: Rename qmc_chan_command()drivers/soc/fsl/qe/qmc.c+3 -31 reply
29/36soc: fsl: cpm1: qmc: Handle RPACK initializationdrivers/soc/fsl/qe/qmc.c+7 -01 reply
30/36soc: fsl: cpm1: qmc: Rename SCC_GSMRL_MODE_QMCdrivers/soc/fsl/qe/qmc.c+2 -21 reply
31/36soc: fsl: cpm1: qmc: Introduce qmc_versiondrivers/soc/fsl/qe/qmc.c+6 -01 reply
32/36soc: fsl: qe: Add resource-managed muram allocatorsdrivers/soc/fsl/qe/qe_common.c include/soc/fsl/qe/qe.h+101 -11 reply
33/36soc: fsl: qe: Add missing PUSHSCHED commandinclude/soc/fsl/qe/qe.h+1 -01 reply
34/36soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementationdrivers/soc/fsl/qe/Kconfig drivers/soc/fsl/qe/qmc.c+204 -141 reply
35/36soc: fsl: cpm1: qmc: Handle QUICC Engine (QE) soft-qmc firmwaredrivers/soc/fsl/qe/qmc.c+67 -01 reply
36/36MAINTAINERS: Add QE files related to the Freescale QMC controllerMAINTAINERS+1 -01 reply

Reviews trailers per patch

All 36 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)Christophe Leroy
1/36R-b
2/36R-b
3/36R-b
4/36R-b
5/36R-b
6/36R-b
7/36R-b R-b
8/36R-b
9/36R-b
10/36R-b
11/36R-b
12/36R-b
13/36R-b
14/36R-b
15/36R-b
16/36R-b
17/36R-b
18/36R-b
19/36R-b
20/36R-b
21/36R-b
22/36R-b
23/36R-b
24/36R-b
25/36R-b
26/36R-b
27/36R-b
28/36R-b
29/36R-b
30/36R-b
31/36R-b
32/36R-b
33/36R-b
34/36R-b
35/36R-b
36/36R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/36] soc: fsl: Add support for QUICC Engine TSA and QMC

Hi,

This series add support for the QUICC Engine (QE) version of TSA and QMC components.

CPM1 version is already supported and, as the QE version of those component are pretty similar to the CPM1 version, the series extend the already existing drivers to support for the QE version.

The TSA and QMC components are tightly coupled and so the series provides modifications on both components.
Of course, this series can be split if it is needed. Let me know.

The series is composed of:
- Patches 1 and 2: Fixes related to TRNSYNC in the QMC driver
- Patches 3..6: Fixes of checkpatch detected issues in the TSA driver
- Patch 7: The QE TSA device-tree binding
- Patches 8..13: TSA driver preparations for adding support for QE
- Patches 14 and 15: The support for QE in TSA + MAINTAINERS update
- Patch 16: A TSA API improvement needed for the QE QMC driver
- Patch 17: A clarification in the QE QMC driver
- Patches 18..22: Fixes of checkpatch detected issues in the QMC driver
- Patch 23: The QE QMC device-tree binding
- Patches 24..31: QMC driver preparations for adding support for QE
- Patches 32 and 33: Missing features additions in QE code
- Patches 34..36: The QMC support for QE in QMC + MAINTAINERS update

Compared to the previous iteration, this v2 series updates device-tree bindings and fixes issues detected by kernel test robots.

Related to the QE QMC device-tree binding, I kept the unit address in decimal and the 3 compatible strings in order to avoid blocking the review waiting for a confirmation. Of course, this can be change in a next iteration.

Best regards,
Hervé

Changes v1 -> v2
v1: https://lore.kernel.org/lkml/[email protected]/
- patch 7
Removed redundant sentences
Removed unneeded property names from property descriptions.

- patch 13
Fixed issue detected by a kernel test robot:
cast to smaller integer type 'enum tsa_version' from 'const void *'

- patch 23
Moved channel compatible string to the first item in the channel property list.

- patch 32
Added missing device.h header for devres_* function declarations (issue detected by kernel test robots).

- Other patches
No changes

Herve Codina (36):
soc: fsl: cpm1: qmc: Update TRNSYNC only in transparent mode
soc: fsl: cpm1: qmc: Enable TRNSYNC only when needed
soc: fsl: cpm1: tsa: Fix tsa_write8()
soc: fsl: cpm1: tsa: Use BIT(), GENMASK() and FIELD_PREP() macros
soc: fsl: cpm1: tsa: Fix blank line and spaces
soc: fsl: cpm1: tsa: Add missing spinlock comment
dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controller
soc: fsl: cpm1: tsa: Remove unused registers offset definition
soc: fsl: cpm1: tsa: Use ARRAY_SIZE() instead of hardcoded integer
values
soc: fsl: cpm1: tsa: Make SIRAM entries specific to CPM1
soc: fsl: cpm1: tsa: Introduce tsa_setup() and its CPM1 compatible
version
soc: fsl: cpm1: tsa: Isolate specific CPM1 part from
tsa_serial_{dis}connect()
soc: fsl: cpm1: tsa: Introduce tsa_version
soc: fsl: cpm1: tsa: Add support for QUICC Engine (QE) implementation
MAINTAINERS: Add QE files related to the Freescale TSA controller
soc: fsl: cpm1: tsa: Introduce tsa_serial_get_num()
soc: fsl: cpm1: qmc: Rename QMC_TSA_MASK
soc: fsl: cpm1: qmc: Use BIT(), GENMASK() and FIELD_PREP() macros
soc: fsl: cpm1: qmc: Fix blank line and spaces
soc: fsl: cpm1: qmc: Remove unneeded parenthesis
soc: fsl: cpm1: qmc: Fix 'transmiter' typo
soc: fsl: cpm1: qmc: Add missing spinlock comment
dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller
soc: fsl: cpm1: qmc: Introduce qmc_data structure
soc: fsl: cpm1: qmc: Re-order probe() operations
soc: fsl: cpm1: qmc: Introduce qmc_init_resource() and its CPM1
version
soc: fsl: cpm1: qmc: Introduce qmc_{init,exit}_xcc() and their CPM1
version
soc: fsl: cpm1: qmc: Rename qmc_chan_command()
soc: fsl: cpm1: qmc: Handle RPACK initialization
soc: fsl: cpm1: qmc: Rename SCC_GSMRL_MODE_QMC
soc: fsl: cpm1: qmc: Introduce qmc_version
soc: fsl: qe: Add resource-managed muram allocators
soc: fsl: qe: Add missing PUSHSCHED command
soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation
soc: fsl: cpm1: qmc: Handle QUICC Engine (QE) soft-qmc firmware
MAINTAINERS: Add QE files related to the Freescale QMC controller

 .../bindings/soc/fsl/cpm_qe/fsl,qe-tsa.yaml   | 210 ++++++
 .../soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml        | 197 ++++++
 MAINTAINERS                                   |   3 +
 drivers/soc/fsl/qe/Kconfig                    |  18 +-
 drivers/soc/fsl/qe/qe_common.c                |  80 +++
 drivers/soc/fsl/qe/qmc.c                      | 667 +++++++++++++-----
 drivers/soc/fsl/qe/tsa.c                      | 659 ++++++++++++-----
 drivers/soc/fsl/qe/tsa.h                      |   3 +
 include/dt-bindings/soc/qe-fsl,tsa.h          |  13 +
 include/soc/fsl/qe/qe.h                       |  23 +-
 10 files changed, 1549 insertions(+), 324 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-tsa.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml
 create mode 100644 include/dt-bindings/soc/qe-fsl,tsa.h
Signature · 1 line
2.45.0