Skip to content

net: dsa: vsc73xx: fix MDIO bus access and PHY operations

Pawel Dembicki lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: dsa: vsc73xx: fix phylink capabilitiesdrivers/net/dsa/vitesse-vsc73xx-core.c+2 -12 replies
2/9net: dsa: vsc73xx: fix port MAC configuration in full duplex modedrivers/net/dsa/vitesse-vsc73xx-core.c+5 -10 replies
3/9net: dsa: vsc73xx: pass value in phy_write operationdrivers/net/dsa/vitesse-vsc73xx-core.c+1 -10 replies
4/9net: dsa: vsc73xx: use defined values in phy operationsdrivers/net/dsa/vitesse-vsc73xx-core.c+35 -100 replies
5/9net: dsa: vsc73xx: use mutex to mdio operationsdrivers/net/dsa/vitesse-vsc73xx-core.c drivers/net/dsa/vitesse-vsc73xx.h+47 -141 reply
6/9net: dsa: vsc73xx: speed up mdio bus to max allowed valuedrivers/net/dsa/vitesse-vsc73xx-core.c+17 -33 replies
7/9net: dsa: vsc73xx: allow phy resettingdrivers/net/dsa/vitesse-vsc73xx-core.c+0 -110 replies
8/9net: phy: vitesse: repair vsc73xx autonegotiationdrivers/net/phy/vitesse.c+19 -60 replies
9/9net: phy: vitesse: implement downshift in vsc73xx physdrivers/net/phy/vitesse.c+100 -01 reply

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/9
2/9
3/9
4/9
5/9
6/9R-b
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/9] net: dsa: vsc73xx: fix MDIO bus access and PHY operations

The VSC73xx driver has issues with PHY configuration. This patch series fixes most of them.

The first patch fixes the phylink capabilities, because the MAC in the vsc73xx family doesn't handle 1000BASE HD mode.

The second patch synchronizes the register configuration routine with the datasheet recommendations.

Patches 3-5 restore proper communication on the MDIO bus. Currently, the write value isn't sent to the MDIO register, and without a mutex, communication with the PHY can be interrupted. This causes the PHY to receive improper configuration and autonegotiation could fail.

The sixth patch speeds up the internal MDIO bus to the maximum value allowed by the datasheet.

The seventh patch removes the PHY reset blockade, as it is no longer required.

After fixing the MDIO operations, autonegotiation became possible. The eighth patch removes the blockade, which became unnecessary after the MDIO operations fix. It also enables the MDI-X feature, which is disabled by default in forced 100BASE-TX mode like other Vitesse PHYs.

The last patch implements the downshift feature and enables it by default.

Pawel Dembicki (9):
net: dsa: vsc73xx: fix phylink capabilities
net: dsa: vsc73xx: fix port MAC configuration in full duplex mode
net: dsa: vsc73xx: pass value in phy_write operation
net: dsa: vsc73xx: use defined values in phy operations
net: dsa: vsc73xx: use mutex to mdio operations
net: dsa: vsc73xx: speed up mdio bus to max allowed value
net: dsa: vsc73xx: allow phy resetting
net: phy: vitesse: repair vsc73xx autonegotiation
net: phy: vitesse: implement downshift in vsc73xx phys

 drivers/net/dsa/vitesse-vsc73xx-core.c | 132 ++++++++++++++++++-------
 drivers/net/dsa/vitesse-vsc73xx.h      |   2 +
 drivers/net/phy/vitesse.c              | 125 +++++++++++++++++++++--
 3 files changed, 219 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1