Skip to content

Fix kallsyms with CONFIG_LTO_CLANG

Song Liu linux-trace-kernel live-patching lkml 3 versions – Applied

Status from this message: Applied to for-linus/hardening, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 13 repliesApplied
  2. v23 patches 33 repliesSuperseded
  3. v13 patches 13 repliesSuperseded

Changes in v3 from the cover letter

1. Remove the _without_suffix APIs, as kprobe will not use them. (Masami Hiramatsu)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbolsscripts/kallsyms.c scripts/link-vmlinux.sh+2 -331 reply
2/2kallsyms: Match symbols exactly with CONFIG_LTO_CLANGkernel/kallsyms.c kernel/kallsyms_selftest.c+7 -701 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuis ChamberlainMasami Hiramatsu (Google)Sami TolvanenPetr MladekMiroslav Benes
SeriesR-b T-b R-b R-b A-b A-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG

With CONFIG_LTO_CLANG, the compiler/linker adds .llvm.<hash> suffix to local symbols to avoid duplications. Existing scripts/kallsyms sorts symbols without .llvm.<hash> suffix. However, this causes quite some issues later on. Some users of kallsyms, such as livepatch, have to match symbols exactly.

Address this by sorting full symbols at build time, and let kallsyms lookup APIs to match the symbols exactly.

Changes v2 => v3:
1. Remove the _without_suffix APIs, as kprobe will not use them. (Masami Hiramatsu)

v2: https://lore.kernel.org/live-patching/[email protected]/T/#u

Changes v1 => v2:
1. Update the APIs to remove all .XXX suffixes (v1 only removes .llvm.*).
2. Rename the APIs as *_without_suffix. (Masami Hiramatsu)
3. Fix another user from kprobe. (Masami Hiramatsu)
4. Add tests for the new APIs in kallsyms_selftests.

v1: https://lore.kernel.org/live-patching/[email protected]/T/#u

Song Liu (2):
kallsyms: Do not cleanup .llvm.<hash> suffix before sorting symbols
kallsyms: Match symbols exactly with CONFIG_LTO_CLANG

 kernel/kallsyms.c          | 55 +++++---------------------------------
 kernel/kallsyms_selftest.c | 22 +--------------
 scripts/kallsyms.c         | 31 ++-------------------
 scripts/link-vmlinux.sh    |  4 ---
 4 files changed, 9 insertions(+), 103 deletions(-)

--
2.43.5