Skip to content

virtio-net: unbreak vq resizing if vq coalescing is not supported

Heng Qi netdev virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 2 repliesSuperseded
  3. v21 patch 5 repliesSuperseded

Changes in v4 from the cover letter

- Add a comment for patch[2/2].

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-net: check feature before configuring the vq coalescing commanddrivers/net/virtio_net.c+6 -01 reply
2/2virtio-net: unbreak vq resizing when coalescing is not negotiateddrivers/net/virtio_net.c+6 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchXuan ZhuoEugenio Pé rezJason Wang
1/2A-b
2/2R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH net v4 0/2] virtio-net: unbreak vq resizing if vq coalescing is not supported

Currently, if the driver does not negotiate the vq coalescing feature but supports vq resize, the vq resize action, which could have been successfully executed, is interrupted due to the failure in configuring the vq coalescing parameters. This issue needs to be fixed.

Changelog
=========
v3->v4:
- Add a comment for patch[2/2].

v2->v3:
- Break out the feature check and the fix into separate patches.

v1->v2:
- Rephrase the subject.
- Put the feature check inside the virtnet_send_{r,t}x_ctrl_coal_vq_cmd.

Heng Qi (2):
virtio-net: check feature before configuring the vq coalescing command
virtio-net: unbreak vq resizing when coalescing is not negotiated

 drivers/net/virtio_net.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
Signature · 1 line
2.32.0.3.g01195cf9f