Skip to content

Fix IRQ mutex inversion on cs42l43

Charles Keepax linux-sound 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyIn review
  2. v34 patches 3 repliesSuperseded
  3. v24 patches 1 replySuperseded

Changes in v4 from the cover letter

- Add the missing helper that was causing problems the cs35l45 update.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: cs42l43: Remove redundant semi-colon at end of functionsound/soc/codecs/cs42l43.c+1 -10 replies
2/4ASoC: soc-component: Add new snd_soc_component_get_kcontrol() helpersinclude/sound/soc-component.h sound/soc/soc-component.c+39 -80 replies
3/4ASoC: cs35l45: Use new snd_soc_component_get_kcontrol_locked() helpersound/soc/codecs/cs35l45.c+2 -90 replies
4/4ASoC: cs42l43: Cache shutter IRQ control pointerssound/soc/codecs/cs42l43.c sound/soc/codecs/cs42l43.h+58 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] Fix IRQ mutex inversion on cs42l43

Fix a mutex inversion in the IRQ handling for the speaker shutters on cs42l43. Do this by adding some new helper functions to get kcontrol pointers and caching those in the driver rather than directly acquiring them in the IRQ handler.

Changes in v4:
- Add the missing helper that was causing problems the cs35l45 update.

Changes in v3:
- Also initialise the control cache for the ASP DAI.

Changes in v2:
- Rather than using a work queue for the IRQ handler, cache the control pointers.
- Add some helpers to get kcontrol pointers.
- Update cs35l45 to use the new helper functions.
- Add a patch fixing a pointless semi-colon.

Thanks,
Charles

Charles Keepax (4):
ASoC: cs42l43: Remove redundant semi-colon at end of function
ASoC: soc-component: Add new snd_soc_component_get_kcontrol() helpers
ASoC: cs35l45: Use new snd_soc_component_get_kcontrol_locked() helper
ASoC: cs42l43: Cache shutter IRQ control pointers

 include/sound/soc-component.h |  5 +++
 sound/soc/codecs/cs35l45.c    | 11 +----
 sound/soc/codecs/cs42l43.c    | 75 ++++++++++++++++++++++++++---------
 sound/soc/codecs/cs42l43.h    |  2 +
 sound/soc/soc-component.c     | 42 ++++++++++++++++----
 5 files changed, 100 insertions(+), 35 deletions(-)
Signature · 1 line
2.39.2