Skip to content

ethtool: rss: driver tweaks and netlink context dumps

Jakub Kicinski linux-rdma netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest12 patches 1 replyApplied 12/12
  2. v412 patches 1 replySuperseded
  3. v312 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v212 patches33 repliesSuperseded
v112 patches7 repliesSuperseded

Changes in v5 from the cover letter

- fix build
v4: https://lore.kernel.org/[email protected]
- adjust to the meaning of max context from net
v3: https://lore.kernel.org/[email protected]
- quite a few code comments and commit message changes
- mvpp2: fix interpretation of max_context_id (I'll take care of the net -> net-next merge as needed)
- filter by ifindex in the selftest
v2: https://lore.kernel.org/[email protected]
- fix bugs and build in mvpp2
v1: https://lore.kernel.org/[email protected]

Patches in v5 All 12 applied

#Subject and filesSizeRepliesApplied
1/12selftests: drv-net: rss_ctx: add identifier to traffic commentstools/testing/selftests/drivers/net/hw/rss_ctx.py+2 -20 repliesApplied
2/12eth: mvpp2: implement new RSS context APIdrivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c+79 -430 repliesApplied
3/12eth: mlx5: allow disabling queues when RSS contexts existdrivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c+0 -120 repliesApplied
4/12ethtool: make ethtool_ops::cap_rss_ctx_supported optionalinclude/linux/ethtool.h net/ethtool/ioctl.c net/ethtool/rss.c+8 -40 repliesApplied
5/12eth: remove .cap_rss_ctx_supported from updated driversdrivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c drivers/net/ethernet/sfc/ef100_ethtool.c +1 more+0 -40 repliesApplied
6/12ethtool: rss: don't report key if device doesn't support itdrivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c drivers/net/ethernet/intel/ice/ice_ethtool.c drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +5 more+45 -100 repliesApplied
7/12ethtool: rss: move the device op invocation out of rss_prepare_data()net/ethtool/rss.c+27 -160 repliesApplied
8/12ethtool: rss: report info about additional contexts from XArraynet/ethtool/rss.c+36 -10 repliesApplied
9/12ethtool: rss: support dumping RSS contextsDocumentation/netlink/specs/ethtool.yaml net/ethtool/netlink.c net/ethtool/netlink.h +1 more+146 -20 repliesApplied
10/12ethtool: rss: support skipping contexts during dumpDocumentation/netlink/specs/ethtool.yaml Documentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h +2 more+27 -40 repliesApplied
11/12netlink: specs: decode indirection table as u32 arrayDocumentation/netlink/specs/ethtool.yaml+1 -01 replyApplied
12/12selftests: drv-net: rss_ctx: test dumping RSS contextstools/testing/selftests/drivers/net/hw/rss_ctx.py tools/testing/selftests/net/lib/py/ksft.py+80 -20 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchGal PressmanJoe DamatoEdward CreePetr MachataDonald Hunter
1/12R-b R-b
2/12R-b
3/12R-b R-b
4/12R-b R-b R-b
5/12R-b R-b R-b
6/12R-b R-b
7/12R-b
8/12R-b R-b
9/12R-b R-b
10/12R-b
11/12R-b
12/12R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH net-next v5 00/12] ethtool: rss: driver tweaks and netlink context dumps

This series is a semi-related collection of RSS patches. Main point is supporting dumping RSS contexts via ethtool netlink. At present additional RSS contexts can be queried one by one, and assuming user know the right IDs. This series uses the XArray added by Ed to provide netlink dump support for ETHTOOL_GET_RSS.

Patch 1 is a trivial selftest debug patch.
Patch 2 coverts mvpp2 for no real reason other than that I had
a grand plan of converting all drivers at some stage.
Patch 3 removes a now moot check from mlx5 so that all tests
can pass.
Patch 4 and 5 make a bit used for context support optional,
for easier grepping of drivers which need converting if nothing else.
Patch 6 OTOH adds a new cap bit; some devices don't support
using a different key per context and currently act in surprising ways.
Patch 7 and 8 update the RSS netlink code to use XArray. Patch 9 and 10 add support for dumping contexts. Patch 11 and 12 are small adjustments to spec and a new test.

I'm getting distracted with other work, so probably won't have the time soon to complete next steps, but things which are missing are (and some of these may be bad ideas):

- better discovery

Some sort of API to tell the user who many contexts the device can create. Upper bound, devices often share contexts between ports etc. so it's hard to tell exactly and upfront number of contexts for a netdev. But order of magnitude (4 vs 10s) may be enough for container management system to know whether to bother.

- create/modify/delete via netlink

The only question here is how to handle all the tricky IOCTL legacy. "No change" maps trivially to attribute not present. "reset" (indir_size = 0) probably needs to be a new NLA_FLAG?

- better table size handling

The current API assumes the LUT has fixed size, which isn't true for modern devices. We should have better APIs for the drivers to resize the tables, and in user facing API - the ability to specify pattern and min size rather than exact table expected (sort of like ethtool CLI already does).

- recounted / socket-bound contexts

Support for contexts which get "cleaned up" when their parent netlink socket gets closed. The major catch is that ntuple filters (which we don't currently track) depend on the context, so we need auto-removal for both.

v5:
- fix build
v4: https://lore.kernel.org/[email protected]
- adjust to the meaning of max context from net
v3: https://lore.kernel.org/[email protected]
- quite a few code comments and commit message changes
- mvpp2: fix interpretation of max_context_id (I'll take care of the net -> net-next merge as needed)
- filter by ifindex in the selftest
v2: https://lore.kernel.org/[email protected]
- fix bugs and build in mvpp2
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (12):
selftests: drv-net: rss_ctx: add identifier to traffic comments
eth: mvpp2: implement new RSS context API
eth: mlx5: allow disabling queues when RSS contexts exist
ethtool: make ethtool_ops::cap_rss_ctx_supported optional
eth: remove .cap_rss_ctx_supported from updated drivers
ethtool: rss: don't report key if device doesn't support it
ethtool: rss: move the device op invocation out of rss_prepare_data()
ethtool: rss: report info about additional contexts from XArray
ethtool: rss: support dumping RSS contexts
ethtool: rss: support skipping contexts during dump
netlink: specs: decode indirection table as u32 array
selftests: drv-net: rss_ctx: test dumping RSS contexts

 Documentation/netlink/specs/ethtool.yaml      |  14 +-
 Documentation/networking/ethtool-netlink.rst  |  12 +-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |   2 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |   1 +
 .../net/ethernet/marvell/mvpp2/mvpp2_cls.c    |  18 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_cls.h    |   2 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   | 103 +++++---
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  13 +-
 drivers/net/ethernet/sfc/ef100_ethtool.c      |   2 +-
 drivers/net/ethernet/sfc/ethtool.c            |   2 +-
 include/linux/ethtool.h                       |   7 +-
 include/uapi/linux/ethtool_netlink.h          |   1 +
 net/ethtool/ioctl.c                           |  31 ++-
 net/ethtool/netlink.c                         |   2 +
 net/ethtool/netlink.h                         |   4 +-
 net/ethtool/rss.c                             | 233 ++++++++++++++++--
 .../selftests/drivers/net/hw/rss_ctx.py       |  80 +++++-
 tools/testing/selftests/net/lib/py/ksft.py    |   6 +
 18 files changed, 442 insertions(+), 91 deletions(-)
Signature · 1 line
2.46.0