Generic hotplug support for a PMU with a scope
Status from this message: The following commit has been merged into the perf/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | perf: Generic hotplug support for a PMU with a scopeinclude/ kernel/ | +180 | 7 replies | |
| 2/7 | perf: Add PERF_EV_CAP_READ_SCOPEinclude/ kernel/ | +14 | 2 replies | |
| 3/7 | perf/x86/intel/cstate: Clean up cpumask and hotplugarch/ include/ | +5 | 0 replies | |
| 4/7 | iommu/vt-d: Clean up cpumask and hotplug for perfmondrivers/ drivers/ | +2 | 0 replies | |
| 5/7 | dmaengine: idxd: Clean up cpumask and hotplug for perfmondrivers/ drivers/ drivers/ | +1 | 2 replies | |
| 6/7 | perf/x86/rapl: Move the pmu allocation out of CPU hotplugarch/ | +30 | 4 replies | |
| 7/7 | perf/x86/rapl: Clean up cpumask and hotplugarch/ include/ | +2 | 0 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Lu Baolu | Dave Jiang | Fenghua Yu |
|---|---|---|---|
| 1/7 | |||
| 2/7 | |||
| 3/7 | |||
| 4/7 | R-b | ||
| 5/7 | R-b | R-b | |
| 6/7 | |||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/7] Generic hotplug support for a PMU with a scope
From: Kan Liang <[email protected]>
The perf subsystem assumes that the counters of a PMU are per-CPU. So the user space tool reads a counter from each CPU in the system wide mode. However, many PMUs don't have a per-CPU counter. The counter is effective for a scope, e.g., a die or a socket. To address this, a cpumask is exposed by the kernel driver to restrict to one CPU to stand for a specific scope. In case the given CPU is removed,
the hotplug support has to be implemented for each such driver.
The codes to support the cpumask and hotplug are very similar.
- Expose a cpumask into sysfs
- Pickup another CPU in the same scope if the given CPU is removed.
- Invoke the perf_pmu_migrate_context() to migrate to a new CPU.
- In event init, always set the CPU in the cpumask to event->cpu
- Usually, an event can be read from any CPU of the scope. (For now, it is only supported by the pkg scope PMU, via PERF_EV_CAP_READ_ACTIVE_PKG, e.g., cstate_pkg, rapl, etc)
Similar duplicated codes are implemented for each such PMU driver. It would be good to introduce a generic infrastructure to avoid such duplication.
The patch series introduce 5 popular scopes, core, die, cluster, pkg, and the system-wide. The PMU drivers for cstate, iommu, idxd and rapl are updated to apply the new infrastructure. The new infrastructure can also be applied for other PMU drivers from different ARCHs as well. But I don't have such platforms. It's not done in this patch series. They can be added later separately.
The uncore driver isn't updated either. Because a per-PMU cpumask is required since commit c74443d92f68 ("perf/x86/uncore: Support per PMU cpumask"). Since different types of PMU share the same hotplug codes, more factor out works and verification are expected. The cleanup of the uncore driver can be done later separately.
Kan Liang (7):
perf: Generic hotplug support for a PMU with a scope
perf: Add PERF_EV_CAP_READ_SCOPE perf/x86/intel/cstate: Clean up cpumask and hotplug iommu/vt-d: Clean up cpumask and hotplug
dmaengine: idxd: Clean up cpumask and hotplug perf/x86/rapl: Move the pmu allocation out of CPU hotplug perf/x86/rapl: Clean up cpumask and hotplug
arch/x86/events/intel/cstate.c | 140 +------------------------- arch/x86/events/rapl.c | 119 ++++++---------------- drivers/dma/idxd/idxd.h | 7 -- drivers/dma/idxd/init.c | 3 - drivers/dma/idxd/perfmon.c | 98 +----------------- drivers/iommu/intel/iommu.h | 2 - drivers/iommu/intel/perfmon.c | 111 +-------------------- include/linux/cpuhotplug.h | 3 - include/linux/perf_event.h | 21 ++++ kernel/events/core.c | 176 ++++++++++++++++++++++++++++++++- 10 files changed, 229 insertions(+), 451 deletions(-)
Signature · 1 line
2.38.1