Skip to content

media: camss: Fixups for large capture frames

Jordan Crouse linux-arm-msm linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: camss: Increase the maximum frame sizedrivers/media/platform/qcom/camss/camss-csid.c drivers/media/platform/qcom/camss/camss-csiphy.c drivers/media/platform/qcom/camss/camss-ispif.c +2 more+13 -134 replies
2/2media: camss: Avoid overwriting vfe clock rates for 8250drivers/media/platform/qcom/camss/camss.c+15 -62 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] media: camss: Fixups for large capture frames

A few small issues discovered while (thus far unsuccessfully) trying to bring up a 64MP sensor. The chosen frame limitation of 8192 seems to be somewhat arbitrary as there don't appear to be any hardware limits on maximum frame size. Double the maximum allowable frame size to accommodate bigger sensors.

Next the larger data sizes end up needing bigger pixel clocks. This exposed a bug for 8250 devices where the VFE clocks are shared between two blocks, but the CSID block is being initialized second and overwriting the carefully selected clock rates from VFE. This was likely not a problem earlier because the lowest VFE clock rate that CSID was selecting was good enough for the family of sensors that were being used.

Jordan Crouse (2):
media: camss: Increase the maximum frame size
media: camss: Avoid overwriting vfe clock rates for 8250

 .../media/platform/qcom/camss/camss-csid.c    |  8 +++----
 .../media/platform/qcom/camss/camss-csiphy.c  |  4 ++--
 .../media/platform/qcom/camss/camss-ispif.c   |  4 ++--
 drivers/media/platform/qcom/camss/camss-vfe.c |  4 ++--
 .../media/platform/qcom/camss/camss-video.c   |  6 +++---
 drivers/media/platform/qcom/camss/camss.c     | 21 +++++++++++++------
 6 files changed, 28 insertions(+), 19 deletions(-)
Signature · 1 line
2.40.1