Skip to content

x86/ioapic: Robustness fix and cleanup

Thomas Gleixner lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/apic branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/15x86/ioapic: Handle allocation failures gracefullyarch/x86/kernel/apic/io_apic.c+22 -241 reply
2/15x86/ioapic: Mark mp_alloc_timer_irq() __initarch/x86/kernel/apic/io_apic.c+2 -21 reply
3/15x86/ioapic: Cleanup structsarch/x86/kernel/apic/io_apic.c+14 -180 replies
4/15x86/ioapic: Use guard() for locking where applicablearch/x86/kernel/apic/io_apic.c+64 -1280 replies
5/15x86/apic: Provide apic_printk() helpersarch/x86/include/asm/apic.h+19 -140 replies
6/15x86/apic: Cleanup apic_printk()sarch/x86/kernel/apic/apic.c+35 -460 replies
7/15x86/ioapic: Cleanup apic_printk()sarch/x86/kernel/apic/io_apic.c+73 -1030 replies
8/15x86/ioapic: Cleanup guarded debug printk()sarch/x86/kernel/apic/io_apic.c+29 -381 reply
9/15x86/mpparse: Cleanup apic_printk()sarch/x86/kernel/mpparse.c+6 -61 reply
10/15iommu/vt-d: Cleanup apic_printk()drivers/iommu/intel/irq_remapping.c+5 -60 replies
11/15x86/ioapic: Move replace_pin_at_irq_node() to the call sitearch/x86/kernel/apic/io_apic.c+18 -220 replies
12/15x86/ioapic: Cleanup commentsarch/x86/kernel/apic/io_apic.c+37 -490 replies
13/15x86/ioapic: Cleanup bracket usagearch/x86/kernel/apic/io_apic.c+18 -160 replies
14/15x86/ioapic: Cleanup line breaksarch/x86/kernel/apic/io_apic.c+18 -370 replies
15/15x86/ioapic: Cleanup remaining coding style issuesarch/x86/kernel/apic/io_apic.c+12 -110 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchQiuxu ZhuoBreno Leitao
SeriesT-b T-b
1/15T-b
2/15R-b
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 00/15] x86/ioapic: Robustness fix and cleanup

Breno reported a panic during testing with failslab in the IO-APIC code. This is a historical leftover and can be handled gracefully.

While looking at that I stumbled over quite some historical leftovers of debug printks, overly big comments for trivialities and a pile of coding style violations.

So after fixing the failslab problem I just went through and modernized the (IO)APIC code.

The series is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/apic

Thanks,

tglx

---
 arch/x86/include/asm/apic.h         |   33 -
 arch/x86/kernel/apic/apic.c         |   81 +--
 arch/x86/kernel/apic/io_apic.c      |  749 ++++++++++++++----------------------
 arch/x86/kernel/mpparse.c           |   12 
 drivers/iommu/intel/irq_remapping.c |   11 
 5 files changed, 369 insertions(+), 517 deletions(-)