Skip to content

KVM: kvm_set_memory_region() cleanups

Sean Christopherson kvm lkml 2 versions – Applied

Status from this message: Applied to kvm-x86 memslots, and pushed

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesApplied
  2. v16 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Keep check_memory_region_flags() where it is. [Xiaoyao]
- Rework the changelog for the last patch to account for the change in motiviation.
- Fix double spaces goofs. [Tao]
- Add a lockdep assertion in the x86 code, too. [Tao]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5KVM: Open code kvm_set_memory_region() into its sole caller (ioctl() API)include/linux/kvm_host.h virt/kvm/kvm_main.c+2 -150 replies
2/5KVM: Assert slots_lock is held when setting memory regionsarch/x86/kvm/x86.c virt/kvm/kvm_main.c+4 -90 replies
3/5KVM: Add a dedicated API for setting KVM-internal memslotsarch/x86/kvm/x86.c include/linux/kvm_host.h virt/kvm/kvm_main.c+15 -64 replies
4/5KVM: x86: Drop double-underscores from __kvm_set_memory_region()arch/x86/kvm/x86.c include/linux/kvm_host.h virt/kvm/kvm_main.c+6 -60 replies
5/5KVM: Disallow all flags for KVM-internal memslotsvirt/kvm/kvm_main.c+3 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchClaudio ImbrendaChristoph SchlameussXiaoyao Li
SeriesR-b A-b R-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] KVM: kvm_set_memory_region() cleanups

Cleanups related to kvm_set_memory_region(), salvaged from similar patches that were flying around when we were sorting out KVM_SET_USER_MEMORY_REGION2.

And, hopefully, the KVM-internal memslots hardening will also be useful for s390's ucontrol stuff (https://lore.kernel.org/all/[email protected]).

v2:
- Keep check_memory_region_flags() where it is. [Xiaoyao]
- Rework the changelog for the last patch to account for the change in motiviation.
- Fix double spaces goofs. [Tao]
- Add a lockdep assertion in the x86 code, too. [Tao]

v1: https://lore.kernel.org/all/[email protected]

Sean Christopherson (5):
KVM: Open code kvm_set_memory_region() into its sole caller (ioctl()
API)
KVM: Assert slots_lock is held when setting memory regions
KVM: Add a dedicated API for setting KVM-internal memslots
KVM: x86: Drop double-underscores from __kvm_set_memory_region()
KVM: Disallow all flags for KVM-internal memslots

 arch/x86/kvm/x86.c       |  7 ++++---
 include/linux/kvm_host.h |  8 +++-----
 virt/kvm/kvm_main.c      | 33 ++++++++++++++-------------------
 3 files changed, 21 insertions(+), 27 deletions(-)

base-commit: 10b2c8a67c4b8ec15f9d07d177f63b563418e948

Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog