Skip to content

Support for rk3568 based QNAP TS433 NAS

Heiko Stuebner u-boot 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 4 repliesIn review
  2. v218 patches 22 repliesSuperseded
  3. v115 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- list qnap/index in doc/boards/index
- add CONFIG_SYS_HAS_NONCACHED_MEMORY to defconfig to fix cache error changes in v2:
- use actual cherry-picked upstream dts commits, now that they are merged

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+21 -00 replies
2/18arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+9 -10 replies
3/18arm64: dts: rockchip: enable uart0 on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+8 -00 replies
4/18arm64: dts: rockchip: enable usb ports on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+105 -00 replies
5/18arm64: dts: rockchip: add stdout path on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+4 -00 replies
6/18arm64: dts: rockchip: enable sata1+2 on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+18 -00 replies
7/18arm64: dts: rockchip: add board-aliases for Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+7 -10 replies
8/18arm64: dts: rockchip: add hdd leds to Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+59 -00 replies
9/18arm64: dts: rockchip: enable the tsadc on the Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+6 -00 replies
10/18arm64: dts: rockchip: add gpio-keys to Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+29 -00 replies
11/18arm64: dts: rockchip: define cpu-supply on the Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+41 -00 replies
12/18arm64: dts: rockchip: add missing pmic information on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+226 -10 replies
13/18arm64: dts: rockchip: enable gpu on Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+5 -00 replies
14/18arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+5 -00 replies
15/18arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+1 -30 replies
16/18arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+1 -00 replies
17/18arm64: dts: rockchip: add product-data eeproms to QNAP TS433dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts+20 -00 replies
18/18board: rockchip: add support for Qnap TS433 devicesarch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi arch/arm/mach-rockchip/rk3568/Kconfig board/qnap/ts433/Kconfig +7 more+239 -04 replies

Reviews trailers per patch

17 of 18 patches have a Reviewed-by or Acked-by.

PatchUwe Kleine-KönigKever YangAndrew Lunn
1/18T-b R-b
2/18T-b
3/18T-b R-b
4/18T-b R-b
5/18T-b R-b
6/18T-b R-b
7/18T-b R-b
8/18T-b R-b
9/18T-b R-b
10/18T-b R-b
11/18T-b R-b
12/18T-b R-b
13/18T-b R-b
14/18T-b R-b
15/18R-b R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/18] Support for rk3568 based QNAP TS433 NAS

Currently QNAP builds a series of RK3568- (and RK3588-) based NAS systems. This series provides support for the 4-bay variant called TS433.

The whole series of devices is pretty similar so adding support for the other variants will be pretty easy, once device-specific devicetrees land.

The cherry-picked dts patches landed in the 6.12-rc1 merge window in the Linux kernel.

This currently goes on top of today's u-boot master.

changes in v3:
- list qnap/index in doc/boards/index
- add CONFIG_SYS_HAS_NONCACHED_MEMORY to defconfig to fix cache error changes in v2:
- use actual cherry-picked upstream dts commits, now that they are merged

Heiko Stuebner (17):
arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433
arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433
arm64: dts: rockchip: enable uart0 on Qnap-TS433
arm64: dts: rockchip: enable usb ports on Qnap-TS433
arm64: dts: rockchip: add stdout path on Qnap-TS433
arm64: dts: rockchip: enable sata1+2 on Qnap-TS433
arm64: dts: rockchip: add board-aliases for Qnap-TS433
arm64: dts: rockchip: add hdd leds to Qnap-TS433
arm64: dts: rockchip: enable the tsadc on the Qnap-TS433
arm64: dts: rockchip: add gpio-keys to Qnap-TS433
arm64: dts: rockchip: define cpu-supply on the Qnap-TS433
arm64: dts: rockchip: add missing pmic information on Qnap-TS433
arm64: dts: rockchip: enable gpu on Qnap-TS433
arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433
arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433
arm64: dts: rockchip: add product-data eeproms to QNAP TS433
board: rockchip: add support for Qnap TS433 devices

Uwe Kleine-König (1):
arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433

 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi    |   6 +
 arch/arm/mach-rockchip/rk3568/Kconfig         |  14 +
 board/qnap/ts433/Kconfig                      |  12 +
 board/qnap/ts433/MAINTAINERS                  |   8 +
 configs/qnap-ts433-rk3568_defconfig           |  87 +++
 doc/board/index.rst                           |   1 +
 doc/board/qnap/index.rst                      |   9 +
 doc/board/qnap/ts433.rst                      |  91 +++
 doc/board/rockchip/rockchip.rst               |   1 +
 .../src/arm64/rockchip/rk3568-qnap-ts433.dts  | 571 +++++++++++++++++-
 include/configs/qnap_ts433.h                  |  10 +
 11 files changed, 804 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi
 create mode 100644 board/qnap/ts433/Kconfig
 create mode 100644 board/qnap/ts433/MAINTAINERS
 create mode 100644 configs/qnap-ts433-rk3568_defconfig
 create mode 100644 doc/board/qnap/index.rst
 create mode 100644 doc/board/qnap/ts433.rst
 create mode 100644 include/configs/qnap_ts433.h
Signature · 1 line
2.45.2