t7004: modernize the style
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 2 repliesIn review
- v58 patches 3 repliesSuperseded
- v48 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 6 patches | 8 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | t7004: remove space after redirect operatorst/ | +25 | 0 replies | |
| 2/8 | t7004: one command per linet/ | +4 | 0 replies | |
| 3/8 | t7004: do not prepare things outside test_expect_successt/ | +360 | 0 replies | |
| 4/8 | t7004: use indented here-doct/ | +19 | 0 replies | |
| 5/8 | t7004: description on the same line as test_expect_successt/ | +83 | 0 replies | |
| 6/8 | t7004: begin the test body on the same line as test_expect_successt/ | +71 | 0 replies | |
| 7/8 | t7004: use single quotes instead of double quotest/ | +35 | 0 replies | |
| 8/8 | t7004: make use of write_scriptt/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.
Cover letter [PATCH v6 0/8] [Newcomer] t7004: modernize the style
- Remove whitespace after the redirect operators.
- Move number of expect files prepared outside of test_expect_success to be inside the tests that use it.
- Split some lines that have two commands into two lines one command each.
- Turn some "<<\EOF" into "<<-\EOF" and indent their body.
- Avoid using pipes in the output from "test-tool ref-store" and write the output to a file.
- Change test_expect_success that are seperated from its name to be on the same line.
- Avoid separating test Description and test body with backslash
- Use single quotes instead of double quotes for test description and body.
- Use write_script which takes care of emitting the #!/bin/sh line and the chmod +x.
There are still tests that could lose exit status to pipe. This needs to be modernized too, I will fix them in another patch series.
AbdAlRahman Gad (8):
t7004: remove space after redirect operators
t7004: one command per line
t7004: do not prepare things outside test_expect_success
t7004: use indented here-doc
t7004: description on the same line as test_expect_success
t7004: begin the test body on the same line as test_expect_success
t7004: use single quotes instead of double quotes
t7004: make use of write_script
t/t7004-tag.sh | 1144 +++++++++++++++++++++++------------------------- 1 file changed, 549 insertions(+), 595 deletions(-)
base-commit: 406f326d271e0bacecdb00425422c5fa3f314930
Signature · 1 line
2.43.0