Skip to content

drm/i915: Fix ttm small BAR placement handling

David Gow dri-devel intel-gfx lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/i915: Allow evicting to use the requested placementdrivers/gpu/drm/i915/gem/i915_gem_ttm.c+0 -11 reply
2/2drm/i915: Attempt to get pages without eviction firstdrivers/gpu/drm/i915/gem/i915_gem_ttm.c+7 -51 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJonathan Cavitt
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drm/i915: Fix ttm small BAR placement handling

From: David Gow <[email protected]>

As described in [1], there have been a couple of regressions in the TTM placement handling for i915, which adversely affect DG2 systems with small BAR. In particular, performance become very poor when eviction from the mappable BAR memory is required, as suboptimal placements can be preferred, leading to thrashing. This often leads to hangs of >10s, during which even the compositor is unusable.

These regressions were largely introduced during the flag rework in commit a78a8da51b36 ("drm/ttm: replace busy placement with flags v6").

The first patch has already been sent out[2]. I'm resending it as part of this series which fixes both known regressions.

Thanks to Justin Brewer for bisecting the issue.

Cheers,
-- David

[1]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11255
[2]: https://lore.kernel.org/dri-devel/[email protected]/

---

David Gow (2):
drm/i915: Allow evicting to use the requested placement drm/i915: Attempt to get pages without eviction first

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Signature · 1 line
2.46.0