Skip to content

Remove support for platform data from matrix keypad driver

Dmitry Torokhov linux-arm-kernel linux-input lkml soc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Input: matrix_keypad - remove support for clustered interruptdrivers/input/keyboard/matrix_keypad.c+22 -390 replies
2/5Input: matrix_keypad - switch to gpiod API and generic device propertiesdrivers/input/keyboard/matrix_keypad.c+185 -1560 replies
3/5ARM: spitz: Use software nodes/properties for the GPIO-driven buttonsarch/arm/mach-pxa/spitz.c+68 -310 replies
4/5ARM: spitz: Use software nodes/properties for the matrix keypadarch/arm/mach-pxa/spitz.c+41 -230 replies
5/5Input: matrix_keypad - remove support for platform datadrivers/input/keyboard/matrix_keypad.c include/linux/input/matrix_keypad.h+3 -1190 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus WalleijArnd Bergmann
SeriesR-b A-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Remove support for platform data from matrix keypad driver

Hi,

This series attempts to remove support for platform data from matrix_keypad driver, and have it use generic device properties only for the keypad configuration. Spitz is the only board [left] that uses platform data.

As part of the migration I am also dropping support for "clustered" interrupt mode, as it was only available through platform data and there are no users of it in the mainline kernel.

Additionally gpio-keys device used by Spitz converted to use device properties instead of platform data.

I would prefer not to have the song and dance of merging first 2 patches through the input tree, waiting, merging the spitz patches through SoC tree, waiting, and finally merging the last patch to matrix keypad through input again, so maybe we could merge it all through SoC? Alternatively, I could merge everything through input. What do you think?

Dmitry Torokhov (5):
Input: matrix_keypad - remove support for clustered interrupt
Input: matrix_keypad - switch to gpiod API and generic device
properties
ARM: spitz: Use software nodes/properties for the GPIO-driven buttons
ARM: spitz: Use software nodes/properties for the matrix keypad
Input: matrix_keypad - remove support for platform data

 arch/arm/mach-pxa/spitz.c              | 163 ++++++++----
 drivers/input/keyboard/matrix_keypad.c | 334 ++++++++++---------------
 include/linux/input/matrix_keypad.h    |  48 ----
 3 files changed, 248 insertions(+), 297 deletions(-)

Thanks.

--
Dmitry