Skip to content

net/smc: introduce ringbufs usage statistics

Wen Gu linux-s390 lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied 2/2
  2. v22 patches 9 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

v3->v2 from the cover letter

- use new helper nla_put_uint() instead of nla_put_u64_64bit().

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net/smc: introduce statistics for allocated ringbufs of link groupinclude/uapi/linux/smc.h net/smc/smc_core.c net/smc/smc_core.h+48 -40 repliesApplied
2/2net/smc: introduce statistics for ringbufs usage of net namespaceinclude/uapi/linux/smc.h net/smc/smc_core.c net/smc/smc_stats.c +1 more+42 -160 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] net/smc: introduce ringbufs usage statistics

Currently, we have histograms that show the sizes of ringbufs that ever used by SMC connections. However, they are always incremental and since SMC allows the reuse of ringbufs, we cannot know the actual amount of ringbufs being allocated or actively used.

So this patch set introduces statistics for the amount of ringbufs that actually allocated by link group and actively used by connections of a certain net namespace, so that we can react based on these memory usage information, e.g. active fallback to TCP.

With appropriate adaptations of smc-tools, we can obtain these ringbufs usage information:

$ smcr -d linkgroup
LG-ID    : 00000500
LG-Role  : SERV
LG-Type  : ASYML
VLAN     : 0
PNET-ID  :
Version  : 1
Conns    : 0
Sndbuf   : 12910592 B    <-
RMB      : 12910592 B    <-

or

$ smcr -d stats
[...]
RX Stats
  Data transmitted (Bytes)      869225943 (869.2M)
  Total requests                 18494479
  Buffer usage  (Bytes)          12910592 (12.31M)  <-
  [...]

TX Stats
Data transmitted (Bytes) 12760884405 (12.76G)
Total requests 36988338
Buffer usage (Bytes) 12910592 (12.31M) <-
[...]
[...]

Change log:
v3->v2
- use new helper nla_put_uint() instead of nla_put_u64_64bit().

v2->v1
https://lore.kernel.org/r/[email protected]/
- remove inline keyword in .c files.
- use local variable in macros to avoid potential side effects.

v1
https://lore.kernel.org/r/[email protected]/

Wen Gu (2):
net/smc: introduce statistics for allocated ringbufs of link group net/smc: introduce statistics for ringbufs usage of net namespace

 include/uapi/linux/smc.h |  6 ++++
 net/smc/smc_core.c       | 68 +++++++++++++++++++++++++++++++++-------
 net/smc/smc_core.h       |  2 ++
 net/smc/smc_stats.c      |  6 ++++
 net/smc/smc_stats.h      | 28 +++++++++++------
 5 files changed, 90 insertions(+), 20 deletions(-)
Signature · 1 line
2.32.0.3.g01195cf9f