Skip to content

drm/mgag200: Handle BMC in dedicated VGA output

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/mgag200: Add VGA-BMC outputdrivers/gpu/drm/mgag200/Makefile drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200eh.c +7 more+83 -71 reply
2/5drm/mgag200: vga-bmc: Transparently handle BMCdrivers/gpu/drm/mgag200/mgag200_vga_bmc.c+48 -23 replies
3/5drm/mgag200: vga-bmc: Control CRTC VIDRST flag from encoderdrivers/gpu/drm/mgag200/mgag200_mode.c drivers/gpu/drm/mgag200/mgag200_vga_bmc.c+18 -31 reply
4/5drm/mgag200: vga-bmc: Control BMC scanout from encoderdrivers/gpu/drm/mgag200/mgag200_g200er.c drivers/gpu/drm/mgag200/mgag200_g200ev.c drivers/gpu/drm/mgag200/mgag200_g200se.c +2 more+20 -151 reply
5/5drm/mgag200: Remove BMC outputdrivers/gpu/drm/mgag200/mgag200_bmc.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200eh.c +6 more+0 -1401 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] drm/mgag200: Handle BMC in dedicated VGA output

Add a separate output for VGA connectors with BMC support. Convert code for server models. Keep the original VGA for regular G200 models.

The VGA-BMC output either reports the connected VGA display or, if that is not available, the BMC. Makes the BMC connector obsolete, so remove it.

The benefit of the VGA-BMC connector is that is works with any userspace. Most userspace compositors have problems configuring the current BMC connector. The BMC connector is now gone and only a VGA connector is present.

A different approach to removing the BMC connector has been tried in [1]. The new series also picks up an idea from an older series, [2] where BMC support is entirely transparent to the CRTC.

[1] https://patchwork.freedesktop.org/series/136084/
[2] https://patchwork.freedesktop.org/series/135931/

Thomas Zimmermann (5):
drm/mgag200: Add VGA-BMC output
drm/mgag200: vga-bmc: Transparently handle BMC drm/mgag200: vga-bmc: Control CRTC VIDRST flag from encoder drm/mgag200: vga-bmc: Control BMC scanout from encoder drm/mgag200: Remove BMC output

 drivers/gpu/drm/mgag200/Makefile          |   1 +
 drivers/gpu/drm/mgag200/mgag200_bmc.c     | 102 --------------
 drivers/gpu/drm/mgag200/mgag200_drv.h     |  13 +-
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  |   6 +-
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c |   6 +-
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |   9 +-
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |   9 +-
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |   6 +-
 drivers/gpu/drm/mgag200/mgag200_g200se.c  |   9 +-
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |   6 +-
 drivers/gpu/drm/mgag200/mgag200_mode.c    |   9 --
 drivers/gpu/drm/mgag200/mgag200_vga_bmc.c | 156 ++++++++++++++++++++++
 12 files changed, 167 insertions(+), 165 deletions(-)
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_vga_bmc.c
Signature · 1 line
2.46.0