Skip to content

wifi: ath10k: Fixed locking bug when setting bitrates.

Rory Little ath10k linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wifi: mac80211: Add non-atomic station iterator.include/net/mac80211.h net/mac80211/util.c+48 -00 replies
2/2wifi: ath10k: Removed atomic iteration in bitrate mask clear.drivers/net/wireless/ath/ath10k/mac.c+3 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] wifi: ath10k: Fixed locking bug when setting bitrates.

We have noticed our kernel locking up when attempting to set bitrates in the ath10k. The fault appears to be the sleep calls from sending a wmi command while an RCU read lock is held. The RCU lock seems unnecessary in this case, as we are already holding the wiphy mutex at that point.

We have introduced an iterator for this event - when the wiphy mutex is held and an RCU lock is unnecessary - and used this iterator in the bitrate mask clearing logic.

Rory Little (2):
wifi: mac80211: Add non-atomic station iterator.
wifi: ath10k: Removed atomic iteration in bitrate mask clear.

 drivers/net/wireless/ath/ath10k/mac.c |  6 +++---
 include/net/mac80211.h                | 18 ++++++++++++++++
 net/mac80211/util.c                   | 30 +++++++++++++++++++++++++++
 3 files changed, 51 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1