Skip to content

virtio_net: Add the check for vdpa's mac address

Cindy Lu qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 8 repliesIn review
  2. v64 patches 8 repliesSuperseded
  3. v54 patches 8 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches1 replySuperseded
v34 patches2 repliesSuperseded
v23 patches5 repliesSuperseded
v13 patches11 repliesSuperseded

Changes in v7 from the cover letter

1. Enable this check by default
2. Address comments and rebase with the latest QEMU

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vhost_vdpa : Add a new parameter to enable check mac addressinclude/net/net.h net/vhost-vdpa.c qapi/net.json+11 -03 replies
2/4virtio_net: Add the check for vdpa's mac addresshw/net/virtio-net.c+39 -11 reply
3/4virtio_net: Add second acceptable configuration for MAC setuphw/net/virtio-net.c+14 -02 replies
4/4virtio_net: Add third acceptable configuration for MAC setup.hw/net/virtio-net.c+11 -02 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchLei Yang
1/4T-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] virtio_net: Add the check for vdpa's mac address

When using a VDPA device, it is important to ensure that the MAC address is correctly set. We add a new parameter to enable this check in this patch series.
Only three MAC configurations are acceptable; any others will fail to boot

The usage is:
....
-netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,check-mac=true\
-device virtio-net-pci,netdev=vhost-vdpa0\
....

tested by ConnectX-6 Dx/vdpa_sim device

change in v3
1. Add a new parameter to enable the check and keep the old behavior
2. Adjust the comment and make it clearer

change in v4
1. Change the new parameter's name to check-mac
2. Change the comment and make it clearer

change in v5
1. These patches haven't been merged for a while, so I rebased them with the latest code and resubmitted

change in v6
1. Address comments
2. Rebase with the latest QEMU

change in v7
1. Enable this check by default
2. Address comments and rebase with the latest QEMU

Cindy Lu (4):
vhost_vdpa : Add a new parameter to enable check mac address
virtio_net: Add the check for vdpa's mac address
virtio_net: Add second acceptable configuration for MAC setup
virtio_net: Add third acceptable configuration for MAC setup.

 hw/net/virtio-net.c | 65 ++++++++++++++++++++++++++++++++++++++++++++-
 include/net/net.h   |  1 +
 net/vhost-vdpa.c    |  5 ++++
 qapi/net.json       |  5 ++++
 4 files changed, 75 insertions(+), 1 deletion(-)
Signature · 1 line
2.45.0