Skip to content

CVE-2024-7409

Eric Blake qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 9 repliesIn review
  2. v32 patches 5 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7nbd: Minor style fixesnbd/server.c qemu-nbd.c+3 -21 reply
2/7nbd/server: Plumb in new args to nbd_client_add()blockdev-nbd.c include/block/nbd.h nbd/server.c +1 more+34 -72 replies
3/7nbd/server: CVE-2024-7409: Change default max-connections to 100block/monitor/block-hmp-cmds.c blockdev-nbd.c include/block/nbd.h +1 more+19 -32 replies
4/7nbd/server: CVE-2024-7409: Drop non-negotiating clientsnbd/server.c nbd/trace-events+31 -11 reply
5/7nbd/server: CVE-2024-7409: Close stray client sockets at shutdownblockdev-nbd.c+34 -12 replies
6/7qemu-nbd: Allow users to adjust handshake limitdocs/tools/qemu-nbd.rst qemu-nbd.c+31 -150 replies
7/7nbd/server: Allow users to adjust handshake limit in QMPblock/monitor/block-hmp-cmds.c blockdev-nbd.c include/block/nbd.h +1 more+28 -90 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH for-9.1 v4 0/7] CVE-2024-7409

v3 was here:
https://lists.gnu.org/archive/html/qemu-devel/2024-08/msg00818.html

since then:
- re-add a minor patch from v2 (now patch 1)
- refactor how the client opaque pointer is handled (patch 2)
- add two new patches to prevent malicious clients from consuming inordinate resources: change the default max-connections from unlimited to capped at 100 (patch 3), and add code to kill any client that takes longer than 10 seconds after connect to reach NBD_OPT_GO (patch 4) [Dan]
- squash the connection list handling into a single patch (5) [Dan]
- two new additional patches for reverting back to 9.0 behavior for integration testing purposes; I'm okay if these last two miss 9.1

Eric Blake (7):
nbd: Minor style fixes
nbd/server: Plumb in new args to nbd_client_add() nbd/server: CVE-2024-7409: Change default max-connections to 100 nbd/server: CVE-2024-7409: Drop non-negotiating clients nbd/server: CVE-2024-7409: Close stray client sockets at shutdown
qemu-nbd: Allow users to adjust handshake limit nbd/server: Allow users to adjust handshake limit in QMP

 docs/tools/qemu-nbd.rst        |  5 +++
 qapi/block-export.json         | 18 +++++++---
 include/block/nbd.h            | 20 +++++++++--
 block/monitor/block-hmp-cmds.c |  3 +-
 blockdev-nbd.c                 | 62 +++++++++++++++++++++++++++++++---
 nbd/server.c                   | 51 +++++++++++++++++++++++++---
 qemu-nbd.c                     | 44 ++++++++++++++++--------
 nbd/trace-events               |  1 +
 8 files changed, 173 insertions(+), 31 deletions(-)
Signature · 1 line
2.45.2