Skip to content

drm/ast: Transparently handle BMC in outputs

Thomas Zimmermann dri-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 2 repliesIn review
  2. v29 patches 8 repliesSuperseded
  3. v19 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- track physical connector status in struct ast_connector v2:
- fix reading EDID data on ASTDP and DP501 chips (Jocelyn)

[1] https://patchwork.freedesktop.org/series/136885/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/ast: Move code for physical outputs into separate filesdrivers/gpu/drm/ast/Makefile drivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_dp501.c +4 more+530 -4930 replies
2/11drm/ast: Add struct ast_connectordrivers/gpu/drm/ast/ast_dp.c drivers/gpu/drm/ast/ast_dp501.c drivers/gpu/drm/ast/ast_drv.h +3 more+75 -151 reply
3/11drm/ast: astdp: Move locking into EDID helperdrivers/gpu/drm/ast/ast_dp.c+10 -140 replies
4/11drm/ast: astdp: Use struct drm_edid and helpersdrivers/gpu/drm/ast/ast_dp.c+29 -260 replies
5/11drm/ast: astdp: Simplify power management when detecting displaydrivers/gpu/drm/ast/ast_dp.c+6 -131 reply
6/11drm/ast: astdp: Transparently handle BMC supportdrivers/gpu/drm/ast/ast_dp.c+31 -120 replies
7/11drm/ast: dp501: Use struct drm_edid and helpersdrivers/gpu/drm/ast/ast_dp501.c+22 -370 replies
8/11drm/ast: dp501: Transparently handle BMC supportdrivers/gpu/drm/ast/ast_dp501.c+25 -80 replies
9/11drm/ast: sil164: Transparently handle BMC supportdrivers/gpu/drm/ast/ast_sil164.c+25 -20 replies
10/11drm/ast: vga: Transparently handle BMC supportdrivers/gpu/drm/ast/ast_vga.c+25 -20 replies
11/11drm/ast: Remove BMC outputdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+0 -1260 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJocelyn Falempe
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/11] drm/ast: Transparently handle BMC in outputs

Add transparent BMC support to all outputs. If the user disconnects the physical display, each output will now return display modes for the BMC. Makes the BMC connector obsolete, so remove it.

The benefit of the new approach is that is works with any userspace. Most userspace compositors have problems configuring the current BMC connector. The BMC connector is now gone and only a physical connector is present.

Also clean up some of the EDID handling in preparation. Switching to struct drm_edid and its helpers simplifies the code for inclusion of the BMC support.

A similar approach has been taken for mgag200. [1] Here a server's display hardware also contains an internal BMC that needs to display even without the presence of a physical display.

v3:
- track physical connector status in struct ast_connector v2:
- fix reading EDID data on ASTDP and DP501 chips (Jocelyn)

[1] https://patchwork.freedesktop.org/series/136885/

Thomas Zimmermann (11):
drm/ast: Move code for physical outputs into separate files drm/ast: Add struct ast_connector
drm/ast: astdp: Move locking into EDID helper drm/ast: astdp: Use struct drm_edid and helpers drm/ast: astdp: Simplify power management when detecting display drm/ast: astdp: Transparently handle BMC support drm/ast: dp501: Use struct drm_edid and helpers drm/ast: dp501: Transparently handle BMC support drm/ast: sil164: Transparently handle BMC support drm/ast: vga: Transparently handle BMC support drm/ast: Remove BMC output

 drivers/gpu/drm/ast/Makefile     |   4 +-
 drivers/gpu/drm/ast/ast_dp.c     | 242 ++++++++++++-
 drivers/gpu/drm/ast/ast_dp501.c  | 184 ++++++++--
 drivers/gpu/drm/ast/ast_drv.h    |  42 +--
 drivers/gpu/drm/ast/ast_mode.c   | 578 -------------------------------
 drivers/gpu/drm/ast/ast_sil164.c | 127 +++++++
 drivers/gpu/drm/ast/ast_vga.c    | 127 +++++++
 7 files changed, 667 insertions(+), 637 deletions(-)
 create mode 100644 drivers/gpu/drm/ast/ast_sil164.c
 create mode 100644 drivers/gpu/drm/ast/ast_vga.c
Signature · 1 line
2.46.0