Skip to content

t: port reftable/stack_test.c to the unit testing framework

Chandra Pratap git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6t: move reftable/stack_test.c to the unit testing frameworkMakefile reftable/reftable-tests.h t/helper/test-reftable.c +1 more+175 -1790 replies
2/6t: harmonize t-reftable-stack.c with coding guidelinest/unit-tests/t-reftable-stack.c+61 -672 replies
3/6t-reftable-stack: use Git's tempfile API instead of mkstemp()t/unit-tests/t-reftable-stack.c+3 -12 replies
4/6t-reftable-stack: use reftable_ref_record_equal() to compare ref recordst/unit-tests/t-reftable-stack.c+2 -33 replies
5/6t-reftable-stack: add test for non-default compaction factort/unit-tests/t-reftable-stack.c+37 -40 replies
6/6t-reftable-stack: add test for stack iteratorst/unit-tests/t-reftable-stack.c+82 -01 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchPatrick SteinhardtChristian Couder
SeriesMentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by Mentored-by
1/6Mentored-by Mentored-by
2/6Mentored-by Mentored-by
3/6Mentored-by Mentored-by
4/6Mentored-by Mentored-by
5/6Mentored-by Mentored-by
6/6Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [GSoC][PATCH 0/6] t: port reftable/stack_test.c to the unit testing framework

The reftable library comes with self tests, which are exercised as part of the usual end-to-end tests and are designed to observe the end-user visible effects of Git commands. What it exercises, however, is a better match for the unit-testing framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', 2023-12-09), which is designed to observe how low level implementation details, at the level of sequences of individual function calls, behave.

Hence, port reftable/stack_test.c to the unit testing framework and improve upon the ported test. The first patch in the series moves the test to the unit testing framework, and the rest of the patches improve upon the ported test.

---
CI/PR: https://github.com/gitgitgadget/git/pull/1762

Chandra Pratap(6):
t: move reftable/stack_test.c to the unit testing framework
t: harmonize t-reftable-stack.c with coding guidelines
t-reftable-stack: use Git's tempfile API instead of mkstemp()
t-reftable-stack: use reftable_ref_record_equal() to compare ref records
t-reftable-stack: add test for non-default compaction factor
t-reftable-stack: add test for stack iterators

Makefile                                                 |   2 +-
reftable/reftable-tests.h                                |   1 -
t/helper/test-reftable.c                                 |   1 -
reftable/stack_test.c => t/unit-tests/t-reftable-stack.c | 600 +++++++++++++++++++--------------
4 files changed, 355 insertions(+), 249 deletions(-)