t: port reftable/stack_test.c to the unit testing framework
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | t: move reftable/stack_test.c to the unit testing frameworkMakefile reftable/ t/ +1 more | +175 | 0 replies | |
| 2/6 | t: harmonize t-reftable-stack.c with coding guidelinest/ | +61 | 2 replies | |
| 3/6 | t-reftable-stack: use Git's tempfile API instead of mkstemp()t/ | +3 | 2 replies | |
| 4/6 | t-reftable-stack: use reftable_ref_record_equal() to compare ref recordst/ | +2 | 3 replies | |
| 5/6 | t-reftable-stack: add test for non-default compaction factort/ | +37 | 0 replies | |
| 6/6 | t-reftable-stack: add test for stack iteratorst/ | +82 | 1 reply |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [GSoC][PATCH 0/6] t: port reftable/stack_test.c to the unit testing framework
The reftable library comes with self tests, which are exercised as part of the usual end-to-end tests and are designed to observe the end-user visible effects of Git commands. What it exercises, however, is a better match for the unit-testing framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', 2023-12-09), which is designed to observe how low level implementation details, at the level of sequences of individual function calls, behave.
Hence, port reftable/stack_test.c to the unit testing framework and improve upon the ported test. The first patch in the series moves the test to the unit testing framework, and the rest of the patches improve upon the ported test.
---
CI/PR: https://github.com/gitgitgadget/git/pull/1762
Chandra Pratap(6):
t: move reftable/stack_test.c to the unit testing framework
t: harmonize t-reftable-stack.c with coding guidelines
t-reftable-stack: use Git's tempfile API instead of mkstemp()
t-reftable-stack: use reftable_ref_record_equal() to compare ref records
t-reftable-stack: add test for non-default compaction factor
t-reftable-stack: add test for stack iterators
Makefile | 2 +- reftable/reftable-tests.h | 1 - t/helper/test-reftable.c | 1 - reftable/stack_test.c => t/unit-tests/t-reftable-stack.c | 600 +++++++++++++++++++-------------- 4 files changed, 355 insertions(+), 249 deletions(-)